Conversation
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
commented
Jan 30, 2026
a10y
force-pushed
the
aduffy/patches-cuda
branch
from
5557930 to
617ade8
Compare
a10y
requested review from
0ax1,
Copilot and
joseph-isaacs
and removed request for
Copilot
a10y
added
changelog/feature
vortex-cuda/kernels/src/patches.cu
Outdated
| const ValueT *const patchValues, | ||
| uint64_t patchesLen | ||
| ) { | ||
| const uint32_t idx = blockIdx.x * blockDim.x + threadIdx.x; |
Contributor
There was a problem hiding this comment.
we do likely want to have each kernel instances patch more than a single value?
joseph-isaacs
approved these changes
Feb 2, 2026
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
Would be nice to address the perf, also maybe TODO saying this is a pretty naive approach
a10y
force-pushed
the
aduffy/patches-cuda
branch
from
4abd87f to
7371736
Compare
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/patches-cuda
branch
from
19b4042 to
7e9717e
Compare
Merging this PR will degrade performance by 33.09%
Performance Changes
Comparing 
Footnotes
|
AdamGS
pushed a commit
that referenced
this pull request
Feb 2, 2026
Apply patches in-place for BP and ALP. Added unit tests, and also added patches to the existing BP/ALP tests to verify it works --------- Signed-off-by: Andrew Duffy <andrew@a10y.dev>
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
Apply patches in-place for BP and ALP. Added unit tests, and also added patches to the existing BP/ALP tests to verify it works --------- Signed-off-by: Andrew Duffy <andrew@a10y.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply patches in-place for BP and ALP.
Added unit tests, and also added patches to the existing BP/ALP tests to verify it works