Conversation
Signed-off-by: Onur Satici <onursatici@gmail.com> Signed-off-by: Onur Satici <onur@spiraldb.com>
Signed-off-by: Onur Satici <onur@spiraldb.com>
Signed-off-by: Onur Satici <onur@spiraldb.com>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
# Conflicts: # vortex-array/src/array/mod.rs # vortex-array/src/array/visitor.rs # vortex-array/src/display/tree.rs # vortex-file/src/open.rs
Deploying vortex-bench with
|
| Latest commit: |
3bdb153
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e62d2354.vortex-93b.pages.dev |
| Branch Preview URL: | https://ji-gpu-scan-2.vortex-93b.pages.dev |
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Merging this PR will degrade performance by 29.9%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| 🆕 | WallTime | 10M_90pct[10000000] |
N/A | 200.7 µs | N/A |
| 🆕 | WallTime | 1M_10pct[100000] |
N/A | 21.8 µs | N/A |
| 🆕 | WallTime | 1M_10pct[100000] |
N/A | 46.7 µs | N/A |
| 🆕 | WallTime | 1M_90pct[1000000] |
N/A | 29.2 µs | N/A |
| 🆕 | WallTime | 10M_90pct[10000000] |
N/A | 367.1 µs | N/A |
| ❌ | WallTime | u32_values_u8_codes[10M] |
133.7 µs | 170.9 µs | -21.75% |
| 🆕 | WallTime | 1M_50pct[500000] |
N/A | 22.8 µs | N/A |
| 🆕 | WallTime | 10M_10pct[1000000] |
N/A | 222.9 µs | N/A |
| 🆕 | WallTime | 10M_10pct[1000000] |
N/A | 218.7 µs | N/A |
| 🆕 | WallTime | 10M_90pct[10000000] |
N/A | 368.3 µs | N/A |
| 🆕 | WallTime | 10M_50pct[5000000] |
N/A | 157.9 µs | N/A |
| 🆕 | WallTime | 1M_10pct[100000] |
N/A | 47.3 µs | N/A |
| 🆕 | WallTime | 10M_50pct[5000000] |
N/A | 282.8 µs | N/A |
| 🆕 | WallTime | 10M_10pct[1000000] |
N/A | 137 µs | N/A |
| 🆕 | WallTime | 1M_90pct[1000000] |
N/A | 56.1 µs | N/A |
| 🆕 | WallTime | 10M_50pct[5000000] |
N/A | 280.4 µs | N/A |
| 🆕 | WallTime | 1M_50pct[500000] |
N/A | 52 µs | N/A |
| 🆕 | WallTime | 1M_90pct[1000000] |
N/A | 58.6 µs | N/A |
| 🆕 | WallTime | 1M_50pct[500000] |
N/A | 51.6 µs | N/A |
| ❌ | Simulation | canonical_into_non_nullable[(10000, 1, 0.1)] |
48 µs | 57.2 µs | -16.06% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Comparing ji/gpu-scan-2 (d1da424) with develop (68130ce)2
Footnotes
-
1323 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(1e401b2) during the generation of this report, so 68130ce was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
0ax1
reviewed
Jan 29, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
0ax1
approved these changes
Jan 29, 2026
gatesn
reviewed
Jan 29, 2026
| use crate::CudaDeviceBuffer; | ||
|
|
||
| #[derive(Clone)] | ||
| pub struct VortexCudaStream(pub Arc<CudaStream>); |
AdamGS
pushed a commit
that referenced
this pull request
Feb 2, 2026
Signed-off-by: Onur Satici <onur@spiraldb.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-authored-by: Onur Satici <onursatici@gmail.com> Co-authored-by: Onur Satici <onur@spiraldb.com>
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
Signed-off-by: Onur Satici <onur@spiraldb.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-authored-by: Onur Satici <onursatici@gmail.com> Co-authored-by: Onur Satici <onur@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a e2e scan test for a vortex file on the GPU