Skip to content

Fix: dont do lazy filters on write #6194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connortsui20 merged 2 commits into from
Jan 28, 2026

fix incorrect tests

4d13e23
Select commit
Loading
Failed to load commit list.
Merged

Fix: dont do lazy filters on write #6194

fix incorrect tests
4d13e23
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Jan 28, 2026 in 0s

Performance Regression: -29.85%

Summary

⚡ 7 improved benchmarks
❌ 10 regressed benchmarks
✅ 1133 untouched benchmarks
⏩ 1334 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation canonical_into_non_nullable[(10000, 1, 0.1)] 48 µs 56.8 µs -15.5%
❌ Simulation canonical_into_non_nullable[(10000, 1, 0.0)] 25.7 µs 36.1 µs -28.78%
❌ Simulation canonical_into_non_nullable[(10000, 10, 0.0)] 195.5 µs 278.7 µs -29.85%
❌ Simulation canonical_into_non_nullable[(10000, 1, 0.01)] 32.2 µs 40.9 µs -21.28%
❌ Simulation canonical_into_non_nullable[(10000, 10, 0.01)] 222.6 µs 305.8 µs -27.22%
❌ Simulation canonical_into_non_nullable[(10000, 10, 0.1)] 382.1 µs 471.4 µs -18.93%
⚡ Simulation into_canonical_non_nullable[(10000, 1, 0.0)] 40.4 µs 33.1 µs +22.14%
⚡ Simulation into_canonical_non_nullable[(10000, 1, 0.01)] 46.3 µs 39.2 µs +17.99%
⚡ Simulation into_canonical_non_nullable[(10000, 1, 0.1)] 62.8 µs 55.3 µs +13.55%
❌ Simulation into_canonical_non_nullable[(10000, 10, 0.0)] 201.6 µs 282.3 µs -28.58%
❌ Simulation into_canonical_non_nullable[(10000, 10, 0.01)] 229.2 µs 309.1 µs -25.83%
❌ Simulation into_canonical_non_nullable[(10000, 10, 0.1)] 385.1 µs 471.5 µs -18.33%
⚡ Simulation canonical_into_nullable[(10000, 100, 0.0)] 5 ms 4.3 ms +14.2%
⚡ Simulation into_canonical_nullable[(10000, 10, 0.0)] 540.8 µs 458.1 µs +18.05%
⚡ Simulation into_canonical_nullable[(10000, 100, 0.0)] 5.1 ms 4.3 ms +16.91%
⚡ Simulation into_canonical_nullable[(10000, 100, 0.1)] 6.9 ms 6.1 ms +13.74%
❌ Simulation into_canonical_nullable[(10000, 10, 0.1)] 632 µs 719.1 µs -12.11%

Footnotes

  1. 1334 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

View more details on CodSpeed HQ