Skip to content

fix: only link nvcomp for linux#6144

Merged
0ax1 merged 1 commit intodevelopfrom
ad/fix-nvcomp-link
Jan 26, 2026
Merged

fix: only link nvcomp for linux#6144
0ax1 merged 1 commit intodevelopfrom
ad/fix-nvcomp-link

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Jan 26, 2026

No description provided.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 added the changelog/fix A bug fix label Jan 26, 2026
Copy link
Contributor

@connortsui20 connortsui20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@0ax1 0ax1 enabled auto-merge (squash) January 26, 2026 16:53
@0ax1 0ax1 merged commit a66a58d into develop Jan 26, 2026
44 of 46 checks passed
@0ax1 0ax1 deleted the ad/fix-nvcomp-link branch January 26, 2026 16:54
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 26, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 29.63%

Comparing ad/fix-nvcomp-link (2c37d11) with develop (277aed9)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 7 improved benchmarks
❌ 3 regressed benchmarks
✅ 1255 untouched benchmarks
⏩ 1294 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime u8_FoR[10M] 8.1 µs 6.3 µs +28.81%
Simulation canonical_into_non_nullable[(10000, 10, 0.01)] 312.3 µs 222.7 µs +40.28%
Simulation canonical_into_non_nullable[(10000, 10, 0.1)] 471.7 µs 382.2 µs +23.43%
Simulation canonical_into_non_nullable[(10000, 10, 0.0)] 285.5 µs 195.6 µs +45.93%
Simulation canonical_into_non_nullable[(10000, 100, 0.1)] 3.7 ms 4.6 ms -18.28%
Simulation canonical_into_non_nullable[(10000, 100, 0.01)] 2.2 ms 3 ms -27%
Simulation canonical_into_non_nullable[(10000, 100, 0.0)] 1.9 ms 2.7 ms -29.63%
Simulation into_canonical_non_nullable[(10000, 10, 0.0)] 290.3 µs 200.2 µs +44.99%
Simulation into_canonical_non_nullable[(10000, 10, 0.01)] 317.1 µs 227.8 µs +39.16%
Simulation into_canonical_non_nullable[(10000, 10, 0.1)] 472.9 µs 383.7 µs +23.26%

Footnotes

  1. 1294 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

danking pushed a commit that referenced this pull request Feb 6, 2026
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants