fix[dtype]: fix typo in conversion from dtype to decimaltype#6121
Merged
joseph-isaacs merged 1 commit intodevelopfrom Jan 23, 2026
Merged
fix[dtype]: fix typo in conversion from dtype to decimaltype#6121joseph-isaacs merged 1 commit intodevelopfrom
dtype to decimaltype#6121joseph-isaacs merged 1 commit intodevelopfrom
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
dtype to decimaltype
0ax1
approved these changes
Jan 23, 2026
Contributor
|
WDYT about adding a test? |
Merging this PR will degrade performance by 41.82%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | u8_FoR[1K] |
16.4 µs | 28.2 µs | -41.82% |
| ⚡ | WallTime | u8_FoR[10K] |
7.5 µs | 5.7 µs | +31.33% |
| ❌ | WallTime | u64_FoR[10K] |
12 µs | 13.6 µs | -11.27% |
| ❌ | WallTime | u16_FoR[10M] |
6.3 µs | 7.9 µs | -21.31% |
| ❌ | WallTime | u32_FoR[1K] |
6.1 µs | 6.9 µs | -10.97% |
Comparing ji/fixup-dbp (ec61e35) with develop (48742f1)
Footnotes
-
1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Contributor
Author
|
Where was just not required |
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.