Skip to content

fix[dtype]: fix typo in conversion from dtype to decimaltype#6121

Merged
joseph-isaacs merged 1 commit intodevelopfrom
ji/fixup-dbp
Jan 23, 2026
Merged

fix[dtype]: fix typo in conversion from dtype to decimaltype#6121
joseph-isaacs merged 1 commit intodevelopfrom
ji/fixup-dbp

Conversation

@joseph-isaacs
Copy link
Contributor

No description provided.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs changed the title fix[cuda]: dbp fix[dtype]: fix typo in convertion from dtype to decimaltype Jan 23, 2026
@joseph-isaacs joseph-isaacs changed the title fix[dtype]: fix typo in convertion from dtype to decimaltype fix[dtype]: fix typo in conversion from dtype to decimaltype Jan 23, 2026
@joseph-isaacs joseph-isaacs added the changelog/fix A bug fix label Jan 23, 2026
@joseph-isaacs joseph-isaacs requested a review from 0ax1 January 23, 2026 12:44
@AdamGS
Copy link
Contributor

AdamGS commented Jan 23, 2026

WDYT about adding a test?

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 23, 2026

Merging this PR will degrade performance by 41.82%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 4 regressed benchmarks
✅ 1269 untouched benchmarks
⏩ 1254 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime u8_FoR[1K] 16.4 µs 28.2 µs -41.82%
WallTime u8_FoR[10K] 7.5 µs 5.7 µs +31.33%
WallTime u64_FoR[10K] 12 µs 13.6 µs -11.27%
WallTime u16_FoR[10M] 6.3 µs 7.9 µs -21.31%
WallTime u32_FoR[1K] 6.1 µs 6.9 µs -10.97%

Comparing ji/fixup-dbp (ec61e35) with develop (48742f1)

Open in CodSpeed

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@joseph-isaacs joseph-isaacs merged commit 0b4b579 into develop Jan 23, 2026
46 of 49 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/fixup-dbp branch January 23, 2026 12:52
@joseph-isaacs
Copy link
Contributor Author

Where was just not required

danking pushed a commit that referenced this pull request Feb 6, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants