fallible scalar_at and validity#6102
Merged
joseph-isaacs merged 8 commits intodevelopfrom Jan 22, 2026
Merged
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/fallible-trait-vtable
branch
from
7192fc7 to
39a8a89
Compare
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
CodSpeed Performance ReportMerging this PR will degrade performance by 43.08%Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | u64_FoR[10K] |
12 µs | 8.1 µs | +48.38% |
| ⚡ | WallTime | u16_FoR[100K] |
12 µs | 9.8 µs | +22.23% |
| ⚡ | WallTime | u32_FoR[1M] |
11.8 µs | 10.1 µs | +17.08% |
| ❌ | WallTime | u8_FoR[1K] |
9.7 µs | 11.2 µs | -13.45% |
| ❌ | WallTime | u64_FoR[1K] |
6.8 µs | 7.9 µs | -14.31% |
| ⚡ | WallTime | u16_FoR[1M] |
6.9 µs | 6 µs | +15.23% |
| ⚡ | WallTime | u8_FoR[10M] |
7.1 µs | 5.6 µs | +27.09% |
| ❌ | WallTime | u16_FoR[10M] |
6.4 µs | 11.2 µs | -43.08% |
| ❌ | WallTime | u8_FoR[1M] |
5.7 µs | 6.8 µs | -14.95% |
| ❌ | Simulation | bench_compare_primitive[(100000, 128)] |
981.6 µs | 1,092.3 µs | -10.14% |
| ❌ | Simulation | bench_compare_primitive[(100000, 2)] |
977.4 µs | 1,088.3 µs | -10.19% |
| ❌ | Simulation | bench_compare_primitive[(100000, 4)] |
977.6 µs | 1,088.3 µs | -10.17% |
| ❌ | Simulation | bench_compare_primitive[(100000, 32)] |
979.3 µs | 1,089.6 µs | -10.12% |
| ❌ | Simulation | bench_compare_primitive[(100000, 8)] |
978 µs | 1,088.3 µs | -10.13% |
| ❌ | Simulation | bench_compare_varbin[(100000, 128)] |
998 µs | 1,110.2 µs | -10.1% |
| ❌ | Simulation | bench_compare_varbin[(100000, 2)] |
981.9 µs | 1,093.6 µs | -10.21% |
| ❌ | Simulation | bench_compare_varbin[(100000, 32)] |
985.9 µs | 1,097.8 µs | -10.19% |
| ❌ | Simulation | bench_compare_varbin[(100000, 4)] |
982.2 µs | 1,093.5 µs | -10.18% |
| ❌ | Simulation | bench_compare_varbin[(100000, 8)] |
982.7 µs | 1,094.2 µs | -10.19% |
| ❌ | Simulation | bench_compare_varbinview[(100000, 2)] |
982.2 µs | 1,093.6 µs | -10.19% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Footnotes
-
1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
a10y
approved these changes
Jan 22, 2026
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
gatesn
reviewed
Jan 22, 2026
vortex-array/src/array/mod.rs
Outdated
Contributor
There was a problem hiding this comment.
I think you may have left a lot of these things around. And annoyingly, if we used .expect not .vortex_expect then clippy would have told us.
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
gatesn
previously requested changes
Jan 22, 2026
Contributor
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
Let's just pause on this one until we know whether optimizer ruels should be fallible. If not, I think Array::filter / Array::slice don't need to be either.
gatesn
dismissed
their stale review
I think it makes sense for optimizer rules to be fallible
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
This PR makes several validity and scalar-related methods fallible (returning VortexResult<T> instead of T). --- Breaking Changes Validity methods (in vortex-array) ``` ┌──────────────────────────────────────┬─────────┬───────────────────────┐ │ Method │ Before │ After │ ├──────────────────────────────────────┼─────────┼───────────────────────┤ │ is_valid(index) │ -> bool │ -> VortexResult<bool> │ ├──────────────────────────────────────┼─────────┼───────────────────────┤ │ all_valid(len) │ -> bool │ -> VortexResult<bool> │ ├──────────────────────────────────────┼─────────┼───────────────────────┤ │ all_invalid(len) │ -> bool │ -> VortexResult<bool> │ ├──────────────────────────────────────┼─────────┼───────────────────────┤ │ slice(range) │ -> Self │ -> VortexResult<Self> │ ├──────────────────────────────────────┼─────────┼───────────────────────┤ │ patch(len, offset, indices, patches) │ -> Self │ -> VortexResult<Self> │ └──────────────────────────────────────┴─────────┴───────────────────────┘ Array patch methods ┌─────────────────────────┬─────────┬───────────────────────┐ │ Type │ Before │ After │ ├─────────────────────────┼─────────┼───────────────────────┤ │ BoolArray::patch() │ -> Self │ -> VortexResult<Self> │ ├─────────────────────────┼─────────┼───────────────────────┤ │ PrimitiveArray::patch() │ -> Self │ -> VortexResult<Self> │ ├─────────────────────────┼─────────┼───────────────────────┤ │ DecimalArray::patch() │ -> Self │ -> VortexResult<Self> │ ``` --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes several validity and scalar-related methods fallible (returning VortexResult instead of T).
Breaking Changes
Validity methods (in vortex-array)