Skip to content

Remove the python feature from vortex-error#6064

Merged
AdamGS merged 7 commits intodevelopfrom
adamg/remove-python-error-feature
Jan 22, 2026
Merged

Remove the python feature from vortex-error#6064
AdamGS merged 7 commits intodevelopfrom
adamg/remove-python-error-feature

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 20, 2026

Instead of using a feature just for an error type, we introduce a new error type that helps us localize the functionality into vortex-python, similarly to the PyVortex type.

Like #6059, this should also help with CI and simplify our internal dependency matrix.

@AdamGS AdamGS requested review from danking and gatesn January 20, 2026 16:15
@AdamGS AdamGS added changelog/break A breaking API change changelog/fix A bug fix labels Jan 20, 2026
@AdamGS AdamGS force-pushed the adamg/remove-python-error-feature branch 2 times, most recently from ac3d92d to 46c19a5 Compare January 20, 2026 16:17
@AdamGS AdamGS changed the title Remove the 'python' feature from vortex-error Remove the python feature from vortex-error Jan 20, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 15.9%

Comparing adamg/remove-python-error-feature (228d8d4) with develop (9d568d4)

Summary

⚡ 10 improved benchmarks
❌ 3 regressed benchmarks
✅ 1241 untouched benchmarks
⏩ 1254 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation canonical_into_non_nullable[(10000, 1, 0.0)] 38.9 µs 30.8 µs +26.35%
Simulation canonical_into_non_nullable[(10000, 1, 0.1)] 60.3 µs 52 µs +15.88%
Simulation canonical_into_non_nullable[(10000, 100, 0.0)] 2.7 ms 1.9 ms +41.87%
Simulation canonical_into_non_nullable[(10000, 1, 0.01)] 44.2 µs 36 µs +22.59%
Simulation canonical_into_non_nullable[(10000, 100, 0.1)] 4.5 ms 3.7 ms +22.01%
Simulation canonical_into_non_nullable[(10000, 100, 0.01)] 2.9 ms 2.1 ms +37.75%
Simulation canonical_into_nullable[(10000, 10, 0.0)] 445.1 µs 529.3 µs -15.9%
Simulation into_canonical_non_nullable[(10000, 100, 0.1)] 4.6 ms 3.8 ms +21.69%
Simulation into_canonical_non_nullable[(10000, 100, 0.01)] 3 ms 2.2 ms +36.49%
Simulation into_canonical_non_nullable[(10000, 100, 0.0)] 2.7 ms 1.9 ms +41.57%
Simulation into_canonical_nullable[(10000, 10, 0.1)] 632.5 µs 710.8 µs -11.02%
Simulation into_canonical_nullable[(10000, 100, 0.0)] 5.2 ms 4.4 ms +18.71%
Simulation into_canonical_nullable[(10000, 10, 0.0)] 452.8 µs 538 µs -15.83%

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS AdamGS enabled auto-merge (squash) January 21, 2026 15:02
impl PyStructArray {
/// Returns the given field of the struct array.
pub fn field(self_: PyRef<'_, Self>, name: &str) -> PyResult<PyArrayRef> {
pub fn field(self_: PyRef<'_, Self>, name: &str) -> Result<PyArrayRef, PyVortexError> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you type alias a PyVortexResult

@AdamGS
Copy link
Contributor Author

AdamGS commented Jan 22, 2026

done

@AdamGS AdamGS requested a review from gatesn January 22, 2026 11:19
@AdamGS AdamGS force-pushed the adamg/remove-python-error-feature branch from 7d06bd1 to 96d012a Compare January 22, 2026 15:05
@AdamGS AdamGS removed the changelog/fix A bug fix label Jan 22, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/remove-python-error-feature branch from 96d012a to 23b633c Compare January 22, 2026 15:58
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS merged commit 591960c into develop Jan 22, 2026
42 of 44 checks passed
@AdamGS AdamGS deleted the adamg/remove-python-error-feature branch January 22, 2026 16:30
danking pushed a commit that referenced this pull request Feb 6, 2026
Instead of using a feature just for an error type, we introduce a new
error type that helps us localize the functionality into
`vortex-python`, similarly to the `PyVortex` type.

Like #6059, this should also help with CI and simplify our internal
dependency matrix.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants