chore[array]: remove CanonicalVTable and move append_to_builder to main VTable#6045
Merged
joseph-isaacs merged 5 commits intodevelopfrom Jan 19, 2026
Merged
chore[array]: remove CanonicalVTable and move append_to_builder to main VTable#6045joseph-isaacs merged 5 commits intodevelopfrom
joseph-isaacs merged 5 commits intodevelopfrom
Conversation
…in VTable Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
…in VTable Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
…in VTable Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
d9891e1 to
b76d9fd
Compare
…in VTable Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Merging this PR will degrade performance by 56.1%
Performance Changes
Comparing Footnotes
|
Contributor
Author
…in VTable Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
gatesn
approved these changes
Jan 19, 2026
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
…in VTable (#6045) Internal Array API break, just use execute --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Array API break, just use execute