Skip to content

performance[vortex-array]: avoid is_valid call in varbinview builder #6033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AdamGS merged 1 commit into from
Jan 19, 2026
Merged

performance[vortex-array]: avoid is_valid call in varbinview builder #6033

AdamGS merged 1 commit into from
Jan 19, 2026

Conversation

@asubiotto
Copy link
Contributor

@asubiotto asubiotto commented Jan 19, 2026

Similar to #5814, this creates a lot of unnecessary CPU usage:

image

@asubiotto
performance[vortex-array]: avoid is_valid call in varbinview builder
22c2e8e 
Similar to #5814, this creates a lot of unnecessary CPU usage.

Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
@asubiotto asubiotto requested a review from AdamGS January 19, 2026 16:10
@asubiotto asubiotto added the changelog/performance A performance improvement label Jan 19, 2026
AdamGS
AdamGS approved these changes Jan 19, 2026
View reviewed changes
Copy link
Contributor

@AdamGS AdamGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice find

@codecov
Copy link

codecov bot commented Jan 19, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.56%. Comparing base (c83de4a) to head (22c2e8e).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/builders/varbinview.rs 66.66% 9 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AdamGS AdamGS merged commit 6838253 into develop Jan 19, 2026
49 of 51 checks passed
@AdamGS AdamGS deleted the asubiotto/builderisvalid branch January 19, 2026 17:05
danking pushed a commit that referenced this pull request Feb 6, 2026
@asubiotto @danking
performance[vortex-array]: avoid is_valid call in varbinview builder (#…
ba7b505 
…6033)

Similar to #5814, this creates a lot of unnecessary CPU usage:

<img width="924" height="423" alt="image"
src="https://github.com/user-attachments/assets/5255cc92-3068-49f1-a636-0dd0c3d14171"
/>

Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gatesn gatesn gatesn approved these changes

@AdamGS AdamGS AdamGS approved these changes

Assignees

No one assigned

Labels

changelog/performance A performance improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asubiotto @gatesn @AdamGS