Skip to content

Fix semver check in CI #6026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamGS merged 1 commit into from
Jan 19, 2026
Merged

Fix semver check in CI #6026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,8 @@ jobs:

- name: Check semver
uses: obi1kenobi/cargo-semver-checks-action@v2
with:
exclude: vortex-cuda

rust-coverage:
name: "Rust tests (coverage) (${{ matrix.suite }})"
Expand Down Expand Up @@ -604,10 +606,10 @@ jobs:
matrix:
include:
- { shard: 1, name: "Core foundation", packages: "vortex-buffer vortex-dtype vortex-error" }
- { shard: 2, name: "Array types", packages: "vortex-array vortex-scalar vortex-vector", features: "--features test-harness" }
- { shard: 2, name: "Array types", packages: "vortex-array vortex-scalar vortex-vector", features: "--features _test-harness" }
- { shard: 3, name: "Main library", packages: "vortex vortex-compute" }
- { shard: 4, name: "Encodings 1", packages: "vortex-alp vortex-bytebool vortex-datetime-parts" }
- { shard: 5, name: "Encodings 2", packages: "vortex-decimal-byte-parts vortex-fastlanes vortex-fsst", features: "--features test-harness" }
- { shard: 5, name: "Encodings 2", packages: "vortex-decimal-byte-parts vortex-fastlanes vortex-fsst", features: "--features _test-harness" }
- { shard: 6, name: "Encodings 3", packages: "vortex-pco vortex-runend vortex-sequence" }
- { shard: 7, name: "Encodings 4", packages: "vortex-sparse vortex-zigzag vortex-zstd" }
- { shard: 8, name: "Storage formats", packages: "vortex-flatbuffers vortex-proto vortex-btrblocks" }
Expand Down
2 changes: 1 addition & 1 deletion encodings/alp/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ vortex-vector = { workspace = true }
divan = { workspace = true }
rand = { workspace = true }
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }

[[bench]]
name = "alp_compress"
Expand Down
2 changes: 1 addition & 1 deletion encodings/bytebool/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ vortex-scalar = { workspace = true }

[dev-dependencies]
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }
2 changes: 1 addition & 1 deletion encodings/datetime-parts/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ vortex-scalar = { workspace = true }

[dev-dependencies]
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }
2 changes: 1 addition & 1 deletion encodings/decimal-byte-parts/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ vortex-scalar = { workspace = true }

[dev-dependencies]
rstest = { workspace = true }
vortex-array = { path = "../../vortex-array", features = ["test-harness"] }
vortex-array = { path = "../../vortex-array", features = ["_test-harness"] }
10 changes: 5 additions & 5 deletions encodings/fastlanes/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ itertools = { workspace = true }
rand = { workspace = true }
rstest = { workspace = true }
vortex-alp = { path = "../alp" }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-fastlanes = { path = ".", features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }
vortex-fastlanes = { path = ".", features = ["_test-harness"] }

[features]
test-harness = ["dep:rand"]
_test-harness = ["dep:rand"]

[[bench]]
name = "bitpacking_take"
Expand All @@ -57,9 +57,9 @@ harness = false
[[bench]]
name = "canonicalize_bench"
harness = false
required-features = ["test-harness"]
required-features = ["_test-harness"]

[[bench]]
name = "compute_between"
harness = false
required-features = ["test-harness"]
required-features = ["_test-harness"]
2 changes: 1 addition & 1 deletion encodings/fastlanes/src/bitpacking/array/bitpack_compress.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ fn bytes_per_exception(ptype: PType) -> usize {
ptype.byte_width() + 4
}

#[cfg(feature = "test-harness")]
#[cfg(feature = "_test-harness")]
pub mod test_harness {
use rand::Rng as _;
use rand::rngs::StdRng;
Expand Down
6 changes: 3 additions & 3 deletions encodings/fsst/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ vortex-scalar = { workspace = true }
vortex-vector = { workspace = true }

[features]
test-harness = ["dep:rand", "vortex-array/test-harness"]
_test-harness = ["dep:rand", "vortex-array/_test-harness"]

[dev-dependencies]
divan = { workspace = true }
rand = { workspace = true }
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }

[[bench]]
name = "fsst_compress"
Expand All @@ -45,7 +45,7 @@ harness = false
[[bench]]
name = "chunked_dict_fsst_builder"
harness = false
required-features = ["test-harness"]
required-features = ["_test-harness"]

[package.metadata.cargo-machete]
ignored = ["fsst-rs"]
2 changes: 1 addition & 1 deletion encodings/fsst/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ mod compress;
mod compute;
mod kernel;
mod ops;
#[cfg(feature = "test-harness")]
#[cfg(feature = "_test-harness")]
pub mod test_utils;
#[cfg(test)]
mod tests;
Expand Down
2 changes: 1 addition & 1 deletion encodings/pco/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ divan = { workspace = true }
mimalloc = { workspace = true }
rand = { workspace = true }
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }

[[bench]]
name = "pco"
Expand Down
2 changes: 1 addition & 1 deletion encodings/runend/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ divan = { workspace = true }
itertools = { workspace = true }
rand = { workspace = true }
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }

[features]
arrow = ["dep:arrow-array"]
Expand Down
2 changes: 1 addition & 1 deletion encodings/sequence/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ vortex-vector = { workspace = true }
[dev-dependencies]
itertools = { workspace = true }
rstest = { workspace = true }
vortex-array = { path = "../../vortex-array", features = ["test-harness"] }
vortex-array = { path = "../../vortex-array", features = ["_test-harness"] }
vortex-file = { path = "../../vortex-file", features = ["tokio"] }
vortex-layout = { path = "../../vortex-layout" }
vortex-session = { path = "../../vortex-session" }
Expand Down
2 changes: 1 addition & 1 deletion encodings/sparse/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ vortex-vector = { workspace = true }
[dev-dependencies]
itertools = { workspace = true }
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }
2 changes: 1 addition & 1 deletion encodings/zigzag/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ zigzag = { workspace = true }

[dev-dependencies]
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }

[lints]
workspace = true
2 changes: 1 addition & 1 deletion encodings/zstd/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ zstd = { workspace = true }
[dev-dependencies]
divan = { workspace = true }
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }

[[bench]]
name = "listview_rebuild"
Expand Down
2 changes: 1 addition & 1 deletion fuzz/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ strum = { workspace = true, features = ["derive"] }

# Vortex core - no default features for WASM compatibility (files feature pulls in tokio)
vortex = { path = "../vortex", default-features = false }
vortex-array = { workspace = true, features = ["arbitrary", "test-harness"] }
vortex-array = { workspace = true, features = ["arbitrary", "_test-harness"] }
vortex-btrblocks = { workspace = true }
vortex-buffer = { workspace = true }
vortex-dtype = { workspace = true, features = ["arbitrary"] }
Expand Down
10 changes: 5 additions & 5 deletions vortex-array/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ arbitrary = [
]
canonical_counter = []
table-display = ["dep:tabled"]
test-harness = ["dep:goldenfile", "dep:rstest", "dep:rstest_reuse"]
_test-harness = ["dep:goldenfile", "dep:rstest", "dep:rstest_reuse"]
serde = [
"dep:serde",
"vortex-buffer/serde",
Expand All @@ -94,7 +94,7 @@ futures = { workspace = true, features = ["executor"] }
insta = { workspace = true }
rand_distr = { workspace = true }
rstest = { workspace = true }
vortex-array = { path = ".", features = ["test-harness", "table-display"] }
vortex-array = { path = ".", features = ["_test-harness", "table-display"] }

[[bench]]
name = "search_sorted"
Expand Down Expand Up @@ -132,17 +132,17 @@ harness = false
[[bench]]
name = "chunked_dict_builder"
harness = false
required-features = ["test-harness"]
required-features = ["_test-harness"]

[[bench]]
name = "dict_compress"
harness = false
required-features = ["test-harness"]
required-features = ["_test-harness"]

[[bench]]
name = "dict_compare"
harness = false
required-features = ["test-harness"]
required-features = ["_test-harness"]

[[bench]]
name = "dict_mask"
Expand Down
2 changes: 1 addition & 1 deletion vortex-array/src/arrays/bool/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ mod vtable;
pub use vtable::BoolMaskedValidityRule;
pub use vtable::BoolVTable;

#[cfg(feature = "test-harness")]
#[cfg(feature = "_test-harness")]
mod test_harness;
2 changes: 1 addition & 1 deletion vortex-array/src/arrays/list/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ mod compute;
mod vtable;
pub use vtable::ListVTable;

#[cfg(feature = "test-harness")]
#[cfg(feature = "_test-harness")]
mod test_harness;

#[cfg(test)]
Expand Down
6 changes: 3 additions & 3 deletions vortex-array/src/arrays/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@

//! All the built-in encoding schemes and arrays.

#[cfg(any(test, feature = "test-harness"))]
#[cfg(any(test, feature = "_test-harness"))]
mod assertions;

#[cfg(any(test, feature = "test-harness"))]
#[cfg(any(test, feature = "_test-harness"))]
pub use assertions::format_indices;

#[cfg(test)]
mod validation_tests;

#[cfg(any(test, feature = "test-harness"))]
#[cfg(any(test, feature = "_test-harness"))]
pub mod dict_test;

mod bool;
Expand Down
2 changes: 1 addition & 1 deletion vortex-array/src/compute/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ mod between;
mod boolean;
mod cast;
mod compare;
#[cfg(feature = "test-harness")]
#[cfg(feature = "_test-harness")]
pub mod conformance;
mod fill_null;
mod filter;
Expand Down
2 changes: 1 addition & 1 deletion vortex-array/src/expr/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ impl Hash for ExactExpr {
}
}

#[cfg(feature = "test-harness")]
#[cfg(feature = "_test-harness")]
pub mod test_harness {
use vortex_dtype::DType;
use vortex_dtype::Nullability;
Expand Down
2 changes: 1 addition & 1 deletion vortex-array/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ pub mod serde;
pub mod session;
pub mod stats;
pub mod stream;
#[cfg(any(test, feature = "test-harness"))]
#[cfg(any(test, feature = "_test-harness"))]
pub mod test_harness;
pub mod validity;
pub mod variants;
Expand Down
2 changes: 1 addition & 1 deletion vortex-btrblocks/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ vortex-zigzag = { workspace = true }
[dev-dependencies]
divan = { workspace = true }
test-with = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }

[features]
# This feature enabled unstable encodings for which we don't guarantee stability.
Expand Down
2 changes: 1 addition & 1 deletion vortex-duckdb/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ vortex-utils = { workspace = true, features = ["dashmap"] }
[dev-dependencies]
jiff = { workspace = true }
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }
vortex-runend = { workspace = true }
vortex-sequence = { workspace = true }

Expand Down
2 changes: 1 addition & 1 deletion vortex-file/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ vortex-zstd = { workspace = true, optional = true }

[dev-dependencies]
tokio = { workspace = true, features = ["full"] }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }
vortex-io = { workspace = true, features = ["tokio"] }
vortex-scan = { workspace = true }

Expand Down
2 changes: 1 addition & 1 deletion vortex-gpu/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ vortex-mask = { workspace = true }
criterion = { version = "0.7", features = ["html_reports"] }
rand = { workspace = true }
rstest = { workspace = true }
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }

[build-dependencies]
vortex-gpu-kernels = { workspace = true }
Expand Down
6 changes: 3 additions & 3 deletions vortex-layout/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ vortex-zstd = { workspace = true, optional = true }
futures = { workspace = true, features = ["executor"] }
rstest = { workspace = true }
tokio = { workspace = true, features = ["rt", "macros"] }
vortex-array = { path = "../vortex-array", features = ["test-harness"] }
vortex-array = { path = "../vortex-array", features = ["_test-harness"] }
vortex-io = { path = "../vortex-io", features = ["tokio"] }
vortex-utils = { workspace = true, features = ["test-harness"] }
vortex-utils = { workspace = true, features = ["_test-harness"] }

[features]
test-harness = []
_test-harness = []
tokio = ["dep:tokio", "vortex-error/tokio"]
zstd = ["dep:vortex-zstd"]

Expand Down
4 changes: 2 additions & 2 deletions vortex-layout/src/segments/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ mod shared;
mod sink;
mod source;

#[cfg(any(test, feature = "test-harness"))]
#[cfg(any(test, feature = "_test-harness"))]
mod test;

use std::fmt::Display;
Expand All @@ -16,7 +16,7 @@ pub use cache::*;
pub use shared::*;
pub use sink::*;
pub use source::*;
#[cfg(any(test, feature = "test-harness"))]
#[cfg(any(test, feature = "_test-harness"))]
pub use test::*;
use vortex_error::VortexError;

Expand Down
2 changes: 1 addition & 1 deletion vortex-python/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ url = { workspace = true }
vortex = { workspace = true, features = ["object_store", "python", "tokio"] }

[dev-dependencies]
vortex-array = { workspace = true, features = ["test-harness"] }
vortex-array = { workspace = true, features = ["_test-harness"] }
2 changes: 1 addition & 1 deletion vortex-scan/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ sketches-ddsketch = { workspace = true }
tracing = { workspace = true }

[dev-dependencies]
vortex-layout = { workspace = true, features = ["test-harness"] }
vortex-layout = { workspace = true, features = ["_test-harness"] }

[features]
default = []
Expand Down
2 changes: 1 addition & 1 deletion vortex-utils/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ workspace = true

[features]
dyn-traits = []
test-harness = ["dashmap", "parking_lot"]
_test-harness = ["dashmap", "parking_lot"]
2 changes: 1 addition & 1 deletion vortex-utils/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ pub mod aliases;
pub mod debug_with;
#[cfg(feature = "dyn-traits")]
pub mod dyn_traits;
#[cfg(feature = "test-harness")]
#[cfg(feature = "_test-harness")]
pub mod env;
Loading