chore: clarify Scalar::cast_to_non_extension invariant assert message #6016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cancaicai <2356672992@qq.com>
robert3005
approved these changes
Jan 18, 2026
robert3005
changed the title
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
…#6016) Improve the Scalar::cast_to_non_extension invariant by adding a descriptive assert message when called with an Extension dtype. This keeps the internal contract strict (panic on misuse) while making debugging easier if the invariant is ever violated. Signed-off-by: cancaicai <2356672992@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the Scalar::cast_to_non_extension invariant by adding a descriptive assert message when called with an Extension dtype. This keeps the internal contract strict (panic on misuse) while making debugging easier if the invariant is ever violated.