Skip to content

Fix: missing patches in alp decompress #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
connortsui20 merged 1 commit into from
Jan 16, 2026
Merged

Fix: missing patches in alp decompress #6007

connortsui20 merged 1 commit into from
Jan 16, 2026

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Jan 16, 2026 •
edited
Loading

Fixes: #5948

@connortsui20 connortsui20 added the changelog/fix A bug fix label Jan 16, 2026
@connortsui20 connortsui20 marked this pull request as draft January 16, 2026 18:57
joseph-isaacs
joseph-isaacs approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@joseph-isaacs joseph-isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cry

@connortsui20 connortsui20 mentioned this pull request Jan 16, 2026
Closed
@connortsui20
fix missing patches in alp decompress
f646c50 
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 marked this pull request as ready for review January 16, 2026 19:03
@connortsui20 connortsui20 enabled auto-merge (squash) January 16, 2026 19:03
robert3005
robert3005 approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very unfortunate bug

@connortsui20 connortsui20 merged commit aa5d235 into develop Jan 16, 2026
48 of 49 checks passed
@connortsui20 connortsui20 deleted the ct/fix-alp-execute branch January 16, 2026 19:11
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.89%. Comparing base (6df2004) to head (f646c50).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
encodings/alp/src/alp/array.rs 93.75% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

danking pushed a commit that referenced this pull request Feb 6, 2026
@connortsui20 @danking
Fix: missing patches in alp decompress (#6007)
a72031c 
Fixes: #5948

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 robert3005 approved these changes

@joseph-isaacs joseph-isaacs joseph-isaacs approved these changes

Assignees

No one assigned

Labels

changelog/fix A bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fuzzing Crash: ALP compare with patches not implemented

3 participants

@connortsui20 @robert3005 @joseph-isaacs