Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 16, 2026

No description provided.

@AdamGS AdamGS requested a review from gatesn January 16, 2026 13:00
@AdamGS AdamGS added the changelog/chore A trivial change label Jan 16, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/static-field-names-fns branch from 379c281 to d624f1b Compare January 16, 2026 13:00
@AdamGS AdamGS requested a review from joseph-isaacs January 16, 2026 13:00
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 16, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 14.63%

Comparing adamg/static-field-names-fns (d624f1b) with develop (49cf3aa)

Summary

⚡ 4 improved benchmarks
✅ 1250 untouched benchmarks
⏩ 1254 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory compress[(1000, 256)] 2.2 KB 1.9 KB +14.63%
Memory compress[(100000, 4096)] 2.9 KB 2.6 KB +10.91%
Memory compress[(10000, 1024)] 2.3 KB 2 KB +13.95%
Memory compress[(10000, 256)] 2.9 KB 2.6 KB +10.91%

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.87%. Comparing base (86b3d02) to head (d624f1b).
⚠️ Report is 5 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AdamGS
Copy link
Contributor Author

AdamGS commented Jan 16, 2026

the codspeed improvements seem possible, min/max is used in a bunch of places in the compressor

@AdamGS AdamGS merged commit b83535a into develop Jan 16, 2026
47 of 48 checks passed
@AdamGS AdamGS deleted the adamg/static-field-names-fns branch January 16, 2026 13:30
danking pushed a commit that referenced this pull request Feb 6, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants