Skip to content

feat[array]: execute::<PrimitiveArray>()#5954

Merged
joseph-isaacs merged 2 commits intodevelopfrom
ji/canonical-primitive
Jan 14, 2026
Merged

feat[array]: execute::<PrimitiveArray>()#5954
joseph-isaacs merged 2 commits intodevelopfrom
ji/canonical-primitive

Conversation

@joseph-isaacs
Copy link
Contributor

@joseph-isaacs joseph-isaacs commented Jan 14, 2026 •
edited
Loading

Special execute with downcast

@joseph-isaacs
wip[array]: execute::Primitive
0c50cf7 
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codecov
Copy link

codecov bot commented Jan 14, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 45.76271% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.35%. Comparing base (f1684e6) to head (84af764).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/executor.rs 37.77% 28 Missing ⚠️
vortex-array/src/arrow/executor/null.rs 0.00% 2 Missing ⚠️
vortex-array/src/canonical_to_vector.rs 0.00% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joseph-isaacs
wip[array]: execute::Primitive
84af764 
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs changed the title wip[array]: execute::Primitive feat[array]: execute::<PrimitiveArray>() Jan 14, 2026
@joseph-isaacs joseph-isaacs marked this pull request as ready for review January 14, 2026 14:55
@joseph-isaacs joseph-isaacs added the changelog/feature A new feature label Jan 14, 2026
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) January 14, 2026 14:55
@joseph-isaacs joseph-isaacs requested review from 0ax1 and gatesn January 14, 2026 14:55
@joseph-isaacs joseph-isaacs merged commit 24c81fa into develop Jan 14, 2026
52 of 54 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/canonical-primitive branch January 14, 2026 15:38
danking pushed a commit that referenced this pull request Feb 6, 2026
@joseph-isaacs @danking
feat[array]: execute::<PrimitiveArray>() (#5954)
d038d91 
Special execute with downcast

---------

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gatesn gatesn gatesn approved these changes

@0ax1 0ax1 Awaiting requested review from 0ax1

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joseph-isaacs @gatesn