Add scan concurrency config for datafusion source#5945
Conversation
| /// during footer parsing. | ||
| pub footer_initial_read_size_bytes: usize, default = DEFAULT_FOOTER_INITIAL_READ_SIZE_BYTES | ||
| /// The per-file Vortex scan concurrency. | ||
| pub scan_concurrency: Option<usize>, default = None |
There was a problem hiding this comment.
doesn't DF let you set this for an entire sessioncontext? do we want to override this on a per-source basis?
There was a problem hiding this comment.
I think that's the copy of VortexOptions that is part of VortexFormat, which propagates it downstream from there through either VortexFormatFactory::create or VortexFormat::file_source
There was a problem hiding this comment.
I was wondering if it makes sense to use the target_partitions config off the environment, but I realize that's different.
Maybe we can make it clear in the doc comment that this is the intra-partition concurrency
There was a problem hiding this comment.
intra-partition was the term I was looking for!
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
25c697a to
f1a5852
Compare
|
This PR has been marked as stale because it has been open for 30 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days |
|
I really forgot about this. Think we still want this @AdamGS ? |
|
yeah I think so, I'll try and unconflict it later today 😢 |
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
f1a5852 to
3ff16ab
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
This PR adds a new configuration to the
FileSourcebased API, allowing users to control the intra-partition scan concurrency.