feat[array]: use execute to return Canonical array not Vector#5895
Merged
joseph-isaacs merged 10 commits intodevelopfrom Jan 12, 2026
Merged
feat[array]: use execute to return Canonical array not Vector#5895joseph-isaacs merged 10 commits intodevelopfrom
Canonical array not Vector#5895joseph-isaacs merged 10 commits intodevelopfrom
Conversation
joseph-isaacs
added
the
action/benchmark-sql
github-actions
bot
removed
the
action/benchmark-sql
Merging this PR will improve performance by 10.71%
Performance Changes
Comparing 
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
joseph-isaacs
added
the
action/benchmark-sql
github-actions
bot
removed
the
action/benchmark-sql
joseph-isaacs
force-pushed
the
ji/execute-canonical
branch
from
da7bd88 to
409aa6a
Compare
joseph-isaacs
changed the title
Canonical array not Vector
joseph-isaacs
commented
Jan 8, 2026
| /// | ||
| /// This is the core operation for dictionary decoding - it expands the dictionary | ||
| /// by looking up each code in the values array. | ||
| pub fn take_canonical(values: Canonical, codes: &PrimitiveArray) -> Canonical { |
Contributor
Author
There was a problem hiding this comment.
we don't need this, but I think we will want this once take compute fn is gone
joseph-isaacs
commented
Jan 8, 2026
| } | ||
|
|
||
| /// Filter a canonical array by a mask, returning a new canonical array. | ||
| pub fn filter_canonical(canonical: Canonical, mask: &Mask) -> Canonical { |
Contributor
Author
There was a problem hiding this comment.
same as take and mask
joseph-isaacs
force-pushed
the
ji/execute-canonical
branch
2 times, most recently
from
a107ea7 to
46424ab
Compare
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/execute-canonical
branch
from
193570d to
dc0e9c9
Compare
Contributor
|
@claude analyze this pr deeply |
0ax1
reviewed
Jan 9, 2026
Contributor
|
Claude finished @0ax1's task in 2m 52s —— View job Deep PR Analysis: "feat[array]: use execute to return
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Author
|
How would you want this split up? |
gatesn
approved these changes
Jan 12, 2026
Contributor
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
Lots of follow ups, notably I think we want the API to be execute::<E>(ctx), but we have to interleave that with some other fixes
| // Method 3: Using the execute() method (this is what would be used in production). | ||
| let executed = bitpacked.into_array().execute_vector(&SESSION).unwrap(); | ||
| let executed = { | ||
| let mut ctx = SESSION.create_execution_ctx(); |
Contributor
There was a problem hiding this comment.
Should we add SESSION.execute(bitpacked.into_array()) as an option?
Contributor
Author
There was a problem hiding this comment.
I think think so, I think the explicitness is okay
| let codes = array.codes().execute(ctx)?.into_primitive(); | ||
| Ok(values.take(&codes)) | ||
| fn execute(array: &Self::Array, ctx: &mut ExecutionCtx) -> VortexResult<Canonical> { | ||
| // TODO(joe): remove take compute fn |
Contributor
There was a problem hiding this comment.
I think this is better worded as "inline Canonical::take functionality alongside DictArray"
| mod list_view; | ||
| mod null; | ||
| mod primitive; | ||
| pub mod null; |
Contributor
Author
There was a problem hiding this comment.
To share logic with the old too arrow
| Ok(match self { | ||
| Canonical::Null(a) => Vector::Null(NullVector::new(a.len())), | ||
| Canonical::Bool(a) => { | ||
| Vector::Bool(BoolVector::new(a.bit_buffer().clone(), a.validity_mask())) |
Contributor
There was a problem hiding this comment.
.validity_mask() performs compute!
joseph-isaacs
added a commit
that referenced
this pull request
Jan 13, 2026
Remove the `VORTEX_OPERATORS` remove the old `to_canonical` method and using `execute::<E>` in its place. This cause CPU compute to return canonical (Not `ArrayRef` as before). see #5895 --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
Remove the `VORTEX_OPERATORS` remove the old `to_canonical` method and using `execute::<E>` in its place. This cause CPU compute to return canonical (Not `ArrayRef` as before). see #5895 --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
execute_canonicalinstead ofexecute[likely no one will need to fix anything since the API is very new