feat: teach TemporalMetadata about its relationship to DTypes #5864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered this implicit mapping from TemporalMetadata to DType by trial-and-error and looking at arrays/datetime/mod.rs. AFAIK, this relationship between temporal type and bitwidth comes from [the arrow specification](https://github.com/apache/arrow/blob/7151dcd6faa6a507d99b33ecc797f3d6a74f45ae/format/Schema.fbs#L246-L277). For arrays, TemporalArray already addresses these issues [1], but for Vortex users who create or manipulate scalars, these methods are valuable. [1] Insofar as temporal array expects you to give it a valid PType (it panics if the width is wrong) but will construct the extension DType for you. Signed-off-by: Daniel King <dan@spiraldb.com>
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robert3005
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this implicit mapping from TemporalMetadata to DType by trial-and-error and looking at arrays/datetime/mod.rs. AFAIK, this relationship between temporal type and bitwidth comes from the arrow
specification.
For arrays, TemporalArray already addresses these issues [1], but for Vortex users who create or manipulate scalars, these methods are valuable.
[1] Insofar as temporal array expects you to give it a valid PType (it panics if the width is
wrong) but will construct the extension DType for you.