Fix: actually actually fix CI #5830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robert3005
approved these changes
Dec 29, 2025
Contributor
Author
|
Ok things are just not implemented, @AdamGS can you take a look at this when you get back? |
Merged
Contributor
Author
|
Nevermind this is fixed in #5830 |
connortsui20
added a commit
that referenced
this pull request
Dec 29, 2025
I think this is finally it after #5830 Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will finally fix it
Note that there is still a datafusion not implemented thing here but I think that is intentional?