Skip to content

Conversation

@connortsui20
Copy link
Contributor

Since the list view "logical" type does not include the sizes and offsets as part of its type, we should allow resizing.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 71.70732% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.03%. Comparing base (aa7a891) to head (f85b3a6).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-vector/src/primitive/cast.rs 78.21% 22 Missing ⚠️
vortex-dtype/src/ptype.rs 43.33% 17 Missing ⚠️
vortex-vector/src/listview/vector_mut.rs 58.33% 15 Missing ⚠️
vortex-vector/src/listview/tests.rs 94.28% 2 Missing ⚠️
vortex-scalar/src/vectors.rs 0.00% 1 Missing ⚠️
vortex-vector/src/vector_mut.rs 0.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@connortsui20 connortsui20 force-pushed the ct/lvv-extend-arbitrary branch from 42c8938 to 19334b9 Compare December 18, 2025 20:19
@connortsui20
Copy link
Contributor Author

@joseph-isaacs I made a small change

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 force-pushed the ct/lvv-extend-arbitrary branch from 19334b9 to f85b3a6 Compare December 18, 2025 21:01
@connortsui20 connortsui20 enabled auto-merge (squash) December 18, 2025 21:04
@connortsui20 connortsui20 merged commit 9159495 into develop Dec 18, 2025
47 checks passed
@connortsui20 connortsui20 deleted the ct/lvv-extend-arbitrary branch December 18, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants