Fix: ListArray take incorrect validity
#5762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
gatesn
approved these changes
Dec 16, 2025
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paultiq
pushed a commit
to paultiq/vortex
that referenced
this pull request
Dec 17, 2025
Fixes vortex-data#5743 Bug was here: ```rust indices_array .validity() .clone() .and(array.validity().clone()), ``` This one is sort of a yikes (it might originally been my code? not sure 😱), so I did some refactoring to make writing the obviously correct code more easily Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5743
Bug was here:
indices_array .validity() .clone() .and(array.validity().clone()),This one is sort of a yikes (it might originally been my code? not sure 😱), so I did some refactoring to make writing the obviously correct code more easily