Skip to content

Conversation

@connortsui20
Copy link
Contributor

Adds a fused bitpacked and filter kernel by mostly porting over the existing filter compute function on BitPackedArray.

Very much WIP

Not really sure how to actually integrate this kernel into the system either so everything is unused.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 requested a review from gatesn December 15, 2025 22:06
@connortsui20 connortsui20 added the changelog/feature A new feature label Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 13.20755% with 138 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.26%. Comparing base (47d6ba7) to head (eb9fcb4).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
.../fastlanes/src/bitpacking/vtable/kernels/filter.rs 2.91% 100 Missing ⚠️
...ngs/fastlanes/src/bitpacking/vtable/kernels/mod.rs 0.00% 20 Missing ⚠️
vortex-array/src/patches.rs 0.00% 5 Missing ⚠️
vortex-vector/src/primitive/generic.rs 0.00% 5 Missing ⚠️
vortex-mask/src/lib.rs 0.00% 3 Missing ⚠️
vortex-compute/src/take/slice/portable.rs 0.00% 2 Missing ⚠️
...decimal-byte-parts/src/decimal_byte_parts/rules.rs 0.00% 1 Missing ⚠️
encodings/fastlanes/src/for/vtable/rules.rs 0.00% 1 Missing ⚠️
vortex-buffer/src/buffer.rs 90.90% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn changed the title [WIP] Feature: add fused bitpack filter kernel Feature: add fused bitpack filter kernel Dec 16, 2025
@gatesn gatesn marked this pull request as ready for review December 16, 2025 09:58
@gatesn gatesn enabled auto-merge (squash) December 16, 2025 09:58
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit 8ebf37a into develop Dec 16, 2025
47 checks passed
@gatesn gatesn deleted the ct/bp-filter branch December 16, 2025 13:15
paultiq pushed a commit to paultiq/vortex that referenced this pull request Dec 17, 2025
Adds a fused bitpacked and filter kernel by mostly porting over the
existing filter compute function on `BitPackedArray`.

Very much WIP

Not really sure how to actually integrate this kernel into the system
either so everything is unused.

---------

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Co-authored-by: Nicholas Gates <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants