feat[array]: duckdb executor #5737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
gatesn
approved these changes
Dec 15, 2025
gatesn
reviewed
Dec 15, 2025
| session: &VortexSession, | ||
| ) -> VortexResult<Box<dyn ColumnExporter>> { | ||
| let validity = array.validity_mask(); | ||
| // DuckDB requires that the validity of the child be a subset of the parent struct so we mask out children with |
Contributor
There was a problem hiding this comment.
I think you should use get_item in that case?
| cache: &ConversionCache, | ||
| session: &VortexSession, | ||
| ) -> VortexResult<Box<dyn ColumnExporter>> { | ||
| let validity = array.validity_mask(); |
Contributor
There was a problem hiding this comment.
See this is weird.. validity_mask is deprecated since it's old "canonical", you should use Validity + execute_mask
paultiq
pushed a commit
to paultiq/vortex
that referenced
this pull request
Dec 17, 2025
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.