Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Dec 11, 2025

No description provided.

joseph-isaacs and others added 7 commits December 11, 2025 12:06
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/fix A bug fix label Dec 11, 2025
@gatesn gatesn enabled auto-merge (squash) December 11, 2025 19:32
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 11, 2025

CodSpeed Performance Report

Merging #5702 will degrade performances by 16.25%

Comparing ngates/fix-logging (1937030) with develop (ad1de1e)

Summary

❌ 53 regressions
✅ 1149 untouched
⏩ 621 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
decode_primitives[f32, (1000, 512)] 26.4 µs 31 µs -14.82%
decode_primitives[f32, (1000, 4)] 24.5 µs 29.1 µs -15.88%
decode_primitives[f32, (1000, 32)] 25.6 µs 30.1 µs -15.23%
decode_primitives[f32, (1000, 8)] 25 µs 29.6 µs -15.5%
decode_primitives[i64, (1000, 128)] 28.9 µs 33.4 µs -13.57%
decode_primitives[i64, (1000, 2)] 28.4 µs 32.9 µs -13.68%
decode_primitives[i64, (1000, 32)] 28.7 µs 33.2 µs -13.59%
decode_primitives[i64, (1000, 4)] 28.3 µs 32.9 µs -13.71%
decode_primitives[i64, (1000, 8)] 28.3 µs 32.8 µs -13.72%
decode_primitives[i64, (1000, 512)] 30.7 µs 35.3 µs -12.87%
decode_primitives[u8, (1000, 2)] 26.7 µs 31.3 µs -14.77%
decode_primitives[u8, (1000, 32)] 24.7 µs 29.3 µs -15.68%
decode_primitives[u8, (1000, 128)] 24.7 µs 29.3 µs -15.67%
decode_primitives[u8, (1000, 8)] 24.7 µs 29.3 µs -15.7%
decode_primitives[u8, (1000, 4)] 24.7 µs 29.3 µs -15.7%
decode_primitives[u8, (1000, 512)] 24.8 µs 29.4 µs -15.64%
chunked_dict_primitive_canonical_into[f32, (1000, 10, 10)] 106 µs 121.9 µs -13.08%
chunked_dict_primitive_canonical_into[f32, (1000, 100, 10)] 107.9 µs 123.9 µs -12.91%
chunked_dict_primitive_canonical_into[f32, (1000, 100, 100)] 860.5 µs 992.9 µs -13.33%
chunked_dict_primitive_canonical_into[f64, (1000, 10, 10)] 146.7 µs 163.1 µs -10.06%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 621 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.53%. Comparing base (ad1de1e) to head (1937030).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
encodings/runend/src/rules.rs 0.00% 8 Missing ⚠️
vortex-layout/src/layouts/flat/reader.rs 0.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gatesn gatesn merged commit af0af75 into develop Dec 11, 2025
85 of 89 checks passed
@gatesn gatesn deleted the ngates/fix-logging branch December 11, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants