Skip to content

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Dec 10, 2025

Tracking Issue: #5652

I separated this out from #5653 just in case we wanted to discuss how to handle take on the view type vectors.

See the module docs for more detail.

After this gets merged I can implement DictArray batch_execute!

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.36%. Comparing base (ede0ad6) to head (6ef1ee1).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-compute/src/take/vector/binaryview.rs 0.00% 7 Missing ⚠️
vortex-compute/src/take/vector/listview.rs 0.00% 7 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@connortsui20 connortsui20 merged commit f8870ae into develop Dec 10, 2025
48 checks passed
@connortsui20 connortsui20 deleted the ct/take-view-vectors branch December 10, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants