Skip to content

Conversation

@joseph-isaacs
Copy link
Contributor

No description provided.

@joseph-isaacs joseph-isaacs changed the title wip feat[vector]: Eq Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 87.17949% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.29%. Comparing base (346b1f6) to head (14a7559).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-vector/src/fixed_size_list/vector.rs 0.00% 22 Missing ⚠️
vortex-vector/src/decimal/generic.rs 0.00% 16 Missing ⚠️
vortex-vector/src/listview/vector.rs 92.22% 15 Missing ⚠️
vortex-vector/src/primitive/vector.rs 33.33% 12 Missing ⚠️
vortex-vector/src/decimal/vector.rs 0.00% 10 Missing ⚠️
vortex-vector/src/vector.rs 56.25% 7 Missing ⚠️
vortex-vector/src/primitive/generic.rs 92.30% 2 Missing ⚠️
vortex-vector/src/bool/vector.rs 97.50% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs marked this pull request as ready for review December 11, 2025 14:01
@joseph-isaacs joseph-isaacs added the changelog/feature A new feature label Dec 11, 2025
@0ax1 0ax1 self-requested a review December 11, 2025 14:15
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) December 11, 2025 14:27
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
// Compare offsets and sizes at valid positions
(0..len).all(|i| {
!validity.value(i)
|| (self_offsets.get_as::<usize>(i) == other_offsets.get_as::<usize>(i)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want usize or u64 here, given that we want to run on wasm32?

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
self.views
.iter()
.zip(other.views.iter())
.enumerate()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also have a test

Copy link
Contributor

@0ax1 0ax1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but double check on having all complex eq fns being unit tested

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 11, 2025

CodSpeed Performance Report

Merging #5681 will improve performances by 10.94%

Comparing ji/vector-eq (14a7559) with develop (96dce46)

Summary

⚡ 1 improvement
✅ 1201 untouched
⏩ 621 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
encode_varbinview[(1000, 2)] 270 µs 243.4 µs +10.94%

Footnotes

  1. 621 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
# Conflicts:
#	vortex-vector/src/binaryview/types.rs
#	vortex-vector/src/listview/scalar.rs
#	vortex-vector/src/struct_/scalar.rs
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs merged commit 4e28866 into develop Dec 12, 2025
47 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/vector-eq branch December 12, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants