Skip to content

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Dec 8, 2025

I think this is everything, I had claude search through all of our actions

@connortsui20 connortsui20 requested review from a10y and gatesn December 8, 2025 23:08
@connortsui20 connortsui20 added the changelog/fix A bug fix label Dec 8, 2025
@connortsui20 connortsui20 force-pushed the ct/check-vortex-nightly branch from a63ad6f to 95924de Compare December 8, 2025 23:13
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 69.69697% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.24%. Comparing base (bf654c4) to head (37852de).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-compute/src/take/slice/portable.rs 71.87% 18 Missing ⚠️
...rray/src/arrays/primitive/compute/take/portable.rs 0.00% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@connortsui20 connortsui20 force-pushed the ct/check-vortex-nightly branch from 95924de to 31734f2 Compare December 8, 2025 23:29
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 force-pushed the ct/check-vortex-nightly branch from 31734f2 to 37852de Compare December 9, 2025 15:51
Base automatically changed from ct/fix-portable-take to develop December 9, 2025 16:18
Copy link
Contributor

@a10y a10y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming ci checks pass this seems fine

@connortsui20 connortsui20 merged commit 37520fd into develop Dec 9, 2025
79 checks passed
@connortsui20 connortsui20 deleted the ct/check-vortex-nightly branch December 9, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants