Skip to content

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Dec 8, 2025

It turns out we are not checking RUSTFLAGS="--cfg vortex_nightly" cargo +nightly nextest run on our CI. I'll add that to our actions in a followup PR.

Also adds some non-trivial tests.

@connortsui20 connortsui20 requested review from a10y and gatesn December 8, 2025 22:50
@connortsui20 connortsui20 added the changelog/fix A bug fix label Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.26%. Comparing base (bf654c4) to head (bc957ff).
⚠️ Report is 1 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vortex-data vortex-data deleted a comment from codspeed-hq bot Dec 8, 2025
@connortsui20 connortsui20 marked this pull request as draft December 9, 2025 14:47
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 marked this pull request as ready for review December 9, 2025 15:50
@connortsui20 connortsui20 enabled auto-merge (squash) December 9, 2025 15:53
Copy link
Contributor

@a10y a10y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@connortsui20 connortsui20 merged commit c0d44ef into develop Dec 9, 2025
117 of 118 checks passed
@connortsui20 connortsui20 deleted the ct/fix-portable-take branch December 9, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants