fix: avoid ListBuilder #5636
fix: avoid ListBuilder #5636
Conversation
Avoid a slow ListBuilder pathway when using to_arrow_list that uses our existing `list_from_list_view`, which has the fastpath for when a ListView is zero-copy to List anyway. Signed-off-by: Andrew Duffy <andrew@a10y.dev>
| list_builder.extend_from_array(&array.to_array()); | ||
| let list_array = list_builder.finish_into_list(); | ||
| // Convert listview -> list, via the fast path when possible. | ||
| let list_array = list_from_list_view(array); |
There was a problem hiding this comment.
Want to add a TODO to extend rebuild to support a target offset + size dtype?
CodSpeed Performance ReportMerging #5636 will improve performances by 11.1%Comparing Summary
Benchmarks breakdown
Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
connortsui20
left a comment
connortsui20
left a comment
There was a problem hiding this comment.
Yep this looks good, I think I just forgot to update this when we did the zctl optimizations
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Avoid reimplementing the slow ListBuilder pathway, use
list_from_list_viewto also get the ZCTL fast path when available