FilterArray

[gatesn]

No description provided.

[codspeed-hq]

CodSpeed Performance Report

Merging #5610 will degrade performances by 15.84%

_{Comparing ngates/filter-array (e40d5e8) with develop (536bca9)}

Summary

❌ 44 regressions
✅ 1114 untouched
⏩ 617 skipped¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	chunked_dict_primitive_canonical_into[f32, (1000, 10, 10)]	106.8 µs	122.5 µs	-12.77%
❌	chunked_dict_primitive_canonical_into[f32, (1000, 10, 100)]	850.3 µs	980.9 µs	-13.32%
❌	chunked_dict_primitive_canonical_into[f32, (1000, 100, 10)]	108.8 µs	124.5 µs	-12.62%
❌	chunked_dict_primitive_canonical_into[f32, (1000, 100, 100)]	867.4 µs	999.4 µs	-13.21%
❌	chunked_dict_primitive_canonical_into[f32, (1000, 1000, 10)]	125 µs	140.9 µs	-11.3%
❌	chunked_dict_primitive_canonical_into[f32, (1000, 1000, 100)]	1 ms	1.2 ms	-11.38%
❌	chunked_dict_primitive_canonical_into[u32, (1000, 10, 10)]	109.5 µs	124.6 µs	-12.14%
❌	chunked_dict_primitive_canonical_into[u32, (1000, 10, 100)]	865.1 µs	990.4 µs	-12.65%
❌	chunked_dict_primitive_canonical_into[u32, (1000, 100, 10)]	108.3 µs	123.5 µs	-12.3%
❌	chunked_dict_primitive_canonical_into[u32, (1000, 100, 100)]	866.7 µs	994.2 µs	-12.83%
❌	chunked_dict_primitive_canonical_into[u32, (1000, 1000, 10)]	125.6 µs	141 µs	-10.87%
❌	chunked_dict_primitive_canonical_into[u32, (1000, 1000, 100)]	1 ms	1.2 ms	-11.11%
❌	chunked_dict_primitive_into_canonical[f32, (1000, 10, 10)]	109.6 µs	125.1 µs	-12.4%
❌	chunked_dict_primitive_into_canonical[f32, (1000, 10, 100)]	851.6 µs	983.8 µs	-13.44%
❌	chunked_dict_primitive_into_canonical[f32, (1000, 100, 10)]	108.6 µs	124.2 µs	-12.54%
❌	chunked_dict_primitive_into_canonical[f32, (1000, 100, 100)]	866.4 µs	997.8 µs	-13.17%
❌	chunked_dict_primitive_into_canonical[f32, (1000, 1000, 10)]	125.7 µs	141.6 µs	-11.21%
❌	chunked_dict_primitive_into_canonical[f32, (1000, 1000, 100)]	1 ms	1.2 ms	-11.27%
❌	chunked_dict_primitive_into_canonical[u32, (1000, 10, 10)]	106.4 µs	121.7 µs	-12.58%
❌	chunked_dict_primitive_into_canonical[u32, (1000, 10, 100)]	828.8 µs	958.4 µs	-13.52%
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

1. 617 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[codecov]

Codecov Report

❌ Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.26%. Comparing base (536bca9) to head (e40d5e8).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
vortex-array/src/arrays/filter/vtable.rs	0.00%	54 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[connortsui20]

would prefer the vtables in different files but if were collapsing them all soon then its not that important

[connortsui20]

lets go