Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Dec 2, 2025

No description provided.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/feature A new feature label Dec 2, 2025
@gatesn gatesn enabled auto-merge (squash) December 2, 2025 14:46
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 2, 2025

CodSpeed Performance Report

Merging #5606 will not alter performance

Comparing ngates/mask-fn (a028d26) with develop (80e01eb)

Summary

✅ 1158 untouched
⏩ 617 skipped1

Footnotes

  1. 617 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 1.16279% with 170 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.42%. Comparing base (80e01eb) to head (a028d26).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/scalar_fns/mask/mod.rs 0.00% 43 Missing ⚠️
vortex-vector/src/primitive/scalar.rs 0.00% 19 Missing ⚠️
vortex-array/src/scalar_fns/mod.rs 5.26% 18 Missing ⚠️
vortex-vector/src/decimal/scalar.rs 0.00% 14 Missing ⚠️
vortex-mask/src/lib.rs 0.00% 5 Missing ⚠️
vortex-vector/src/binaryview/scalar.rs 0.00% 5 Missing ⚠️
vortex-vector/src/bool/scalar.rs 0.00% 5 Missing ⚠️
vortex-vector/src/fixed_size_list/scalar.rs 0.00% 5 Missing ⚠️
vortex-vector/src/listview/scalar.rs 0.00% 5 Missing ⚠️
vortex-vector/src/struct_/scalar.rs 0.00% 5 Missing ⚠️
... and 19 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +83 to +95
match self {
PrimitiveScalar::I8(v) => v.mask_validity(mask),
PrimitiveScalar::I16(v) => v.mask_validity(mask),
PrimitiveScalar::I32(v) => v.mask_validity(mask),
PrimitiveScalar::I64(v) => v.mask_validity(mask),
PrimitiveScalar::U8(v) => v.mask_validity(mask),
PrimitiveScalar::U16(v) => v.mask_validity(mask),
PrimitiveScalar::U32(v) => v.mask_validity(mask),
PrimitiveScalar::U64(v) => v.mask_validity(mask),
PrimitiveScalar::F16(v) => v.mask_validity(mask),
PrimitiveScalar::F32(v) => v.mask_validity(mask),
PrimitiveScalar::F64(v) => v.mask_validity(mask),
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match each scalar?

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn merged commit 51401ca into develop Dec 2, 2025
48 of 82 checks passed
@gatesn gatesn deleted the ngates/mask-fn branch December 2, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants