Skip to content

Conversation

@harryscholes
Copy link

@harryscholes harryscholes commented Dec 1, 2025

I found that I want to know the total number of bytes read when querying a file, not just the distribution of individual IOs. Implemented as a counter metric named vortex.io.read.total_size.

@harryscholes harryscholes changed the title add counter Feature: add total read size counter Dec 1, 2025
@lwwmanning lwwmanning added the feature Release label indicating a new feature or request label Dec 1, 2025
@lwwmanning
Copy link
Contributor

thanks for the contribution @harryscholes !

to fix the DCO check, I recommend running something like git rebase -i origin/develop --signoff (need to signoff every git commit in the PR, see CONTRIBUTING.md for details)

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.59%. Comparing base (89b236b) to head (bd85a8d).
⚠️ Report is 3 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: harryscholes <harryscholes@users.noreply.github.com>
@harryscholes harryscholes force-pushed the harry/read-total-size-counter branch from 9a8f0ef to bd85a8d Compare December 1, 2025 20:33
Copy link
Contributor

@onursatici onursatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, yea sizes would have the reads histogram, all histograms have a count but not a sum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Release label indicating a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants