Feature: add total read size counter#5600
Merged
gatesn merged 2 commits intovortex-data:developfrom Dec 8, 2025
Merged
Conversation
Contributor
|
thanks for the contribution @harryscholes ! to fix the DCO check, I recommend running something like |
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: harryscholes <harryscholes@users.noreply.github.com>
9a8f0ef to
bd85a8d
Compare
onursatici
approved these changes
Dec 3, 2025
Contributor
onursatici
left a comment
There was a problem hiding this comment.
Thanks for the contribution, yea sizes would have the reads histogram, all histograms have a count but not a sum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that I want to know the total number of bytes read when querying a file, not just the distribution of individual IOs. Implemented as a counter metric named
vortex.io.read.total_size.