Skip to content

Feature: add total read size counter#5600

Merged
gatesn merged 2 commits intovortex-data:developfrom
harryscholes:harry/read-total-size-counter
Dec 8, 2025
Merged

Feature: add total read size counter#5600
gatesn merged 2 commits intovortex-data:developfrom
harryscholes:harry/read-total-size-counter

Conversation

@harryscholes
Copy link
Contributor

@harryscholes harryscholes commented Dec 1, 2025

I found that I want to know the total number of bytes read when querying a file, not just the distribution of individual IOs. Implemented as a counter metric named vortex.io.read.total_size.

@harryscholes harryscholes changed the title add counter Feature: add total read size counter Dec 1, 2025
@lwwmanning lwwmanning added the changelog/feature A new feature label Dec 1, 2025
@lwwmanning
Copy link
Contributor

thanks for the contribution @harryscholes !

to fix the DCO check, I recommend running something like git rebase -i origin/develop --signoff (need to signoff every git commit in the PR, see CONTRIBUTING.md for details)

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.23%. Comparing base (0ca315e) to head (3268876).
⚠️ Report is 12 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: harryscholes <harryscholes@users.noreply.github.com>
@harryscholes harryscholes force-pushed the harry/read-total-size-counter branch from 9a8f0ef to bd85a8d Compare December 1, 2025 20:33
Copy link
Contributor

@onursatici onursatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, yea sizes would have the reads histogram, all histograms have a count but not a sum.

@gatesn gatesn enabled auto-merge (squash) December 3, 2025 20:53
@gatesn gatesn merged commit 20edf79 into vortex-data:develop Dec 8, 2025
79 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants