Skip to content

chore: inline alp decompress_from_buffer fn #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0ax1 merged 2 commits into from
Nov 29, 2025
Merged

chore: inline alp decompress_from_buffer fn #5587

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d76a564
chore: inline alp `decompress_from_buffer` fn
0ax1 Nov 29, 2025
486e7c7
mask from parts
0ax1 Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 4 additions & 26 deletions encodings/alp/src/alp/decompress.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ use vortex_dtype::DType;
use vortex_dtype::NativePType;
use vortex_dtype::match_each_unsigned_integer_ptype;
use vortex_error::VortexResult;
use vortex_mask::Mask;
use vortex_vector::Vector;
use vortex_vector::VectorMutOps;
use vortex_vector::VectorOps;
Expand Down Expand Up @@ -59,31 +58,11 @@ pub fn decompress_into_vector<T: ALPFloat>(
patches_vectors: Option<(Vector, Vector, Option<Vector>)>,
patches_offset: usize,
) -> VortexResult<Vector> {
let encoded_primitive = encoded_vector.into_primitive();
let validity = encoded_primitive.validity().clone();
let encoded_mutable = encoded_primitive.into_mut();

let alp_buffer = T::ALPInt::downcast(encoded_mutable).into_parts().0;

decompress_from_buffer::<T>(
alp_buffer,
exponents,
patches_vectors,
patches_offset,
validity,
)
}

fn decompress_from_buffer<T: ALPFloat>(
mut alp_buffer: BufferMut<T::ALPInt>,
exponents: Exponents,
patches_vectors: Option<(Vector, Vector, Option<Vector>)>,
patches_offset: usize,
validity: Mask,
) -> VortexResult<Vector> {
let encoded_primitive = encoded_vector.into_primitive().into_mut();
let (mut alp_buffer, mask) = T::ALPInt::downcast(encoded_primitive).into_parts();
<T>::decode_slice_inplace(alp_buffer.as_mut_slice(), exponents);

// Convert to float buffer.
// SAFETY: `Buffer<T::ALPInt> and `BufferMut<T>` have the same layout.
let mut decoded_buffer: BufferMut<T> = unsafe { transmute(alp_buffer) };

// Apply patches if they exist.
Expand All @@ -105,8 +84,7 @@ fn decompress_from_buffer<T: ALPFloat>(
});
}

let result = PVectorMut::<T>::new(decoded_buffer, validity.into_mut());
Ok(result.freeze().into())
Ok(PVectorMut::<T>::new(decoded_buffer, mask).freeze().into())
}

/// Decompresses an ALP-encoded array in 1024-element chunks.
Expand Down
Loading