Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Nov 28, 2025

In favor of using ScalarFnArray in the future

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn changed the title Remove ExprOptimizer from ArrayOptimizer Remove ExprArray and ExprOptimizer Nov 28, 2025
@gatesn gatesn added the changelog/chore A trivial change label Nov 28, 2025
@gatesn gatesn enabled auto-merge (squash) November 28, 2025 21:08
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 28, 2025

CodSpeed Performance Report

Merging #5585 will degrade performances by 12.44%

Comparing ngates/scalar-fn-impl (668fb43) with develop (ef33c36)

Summary

❌ 2 regressions
✅ 1502 untouched
⏩ 271 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
bench_many_nulls[0.5] 322.7 µs 359 µs -10.13%
bench_many_nulls[0.9] 461.5 µs 527.1 µs -12.44%

Footnotes

  1. 271 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 66.87307% with 107 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.91%. Comparing base (ef33c36) to head (668fb43).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/expr/functions/vtable.rs 0.00% 38 Missing ⚠️
vortex-array/src/session/mod.rs 73.49% 22 Missing ⚠️
vortex-array/src/expr/functions/scalar.rs 0.00% 17 Missing ⚠️
vortex-array/src/optimizer/rules.rs 64.44% 16 Missing ⚠️
vortex-array/src/optimizer/mod.rs 89.47% 14 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gatesn gatesn merged commit 841c7cd into develop Nov 28, 2025
46 of 47 checks passed
@gatesn gatesn deleted the ngates/scalar-fn-impl branch November 28, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants