Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Nov 28, 2025

Sadly this is a large break to the Rust API, but we kept conflicting the modules names within vortex_array with the crate names within the vortex workspace.

Breaking Change

Many types exposed on vortex::* will now be exposed on vortex::array::*.

This script should do it:

#!/bin/bash

# Script to migrate from vortex::* to vortex::array::*
#
# Usage: ./migrate_vortex.sh [directory]

DIR="${1:-.}"

# Modules that stay at vortex:: root level
EXCLUDED="array|buffer|compute|compressor|dtype|encodings|error|expr|file|flatbuffers|io|ipc|layout|mask|metrics|proto|scalar|scan|session|utils"

find "$DIR" -name "*.rs" -type f | while read file; do
    # Step 1: Replace all vortex::X with vortex::array::X
    sed -i.bak -E "s/vortex::([a-zA-Z_][a-zA-Z0-9_]*)/vortex::array::\1/g" "$file"

    # Step 2: Revert excluded modules back to vortex::
    sed -i.bak -E "s/vortex::array::(${EXCLUDED})/vortex::\1/g" "$file"

    # Step 3: Fix any double array:: that got created
    sed -i.bak -E "s/vortex::array::array::/vortex::array::/g" "$file"

    rm -f "${file}.bak"
done

echo "Migration complete!"

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/break A breaking API change label Nov 28, 2025
@gatesn gatesn enabled auto-merge (squash) November 28, 2025 20:38
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.98%. Comparing base (191228e) to head (e6c56b1).
⚠️ Report is 2 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gatesn gatesn merged commit ef33c36 into develop Nov 28, 2025
48 checks passed
@gatesn gatesn deleted the ngates/fix-array-namespace branch November 28, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants