Feature: add take compute for slices

[connortsui20]

Ports over the take implementation on primitive arrays to vortex-compute for take on generic slices.

[codspeed-hq]

CodSpeed Performance Report

Merging #5537 will improve performances by 17.18%

_{Comparing ct/take-slice (8b07ace) with develop (7e1d377)}

Summary

⚡ 5 improvements
✅ 1473 untouched
⏩ 235 skipped¹

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⚡	slice_arrow_buffer[1024]	397.8 ns	339.4 ns	+17.18%
⚡	slice_arrow_buffer[128]	397.8 ns	339.4 ns	+17.18%
⚡	slice_arrow_buffer[16384]	397.8 ns	339.4 ns	+17.18%
⚡	slice_arrow_buffer[2048]	397.8 ns	339.4 ns	+17.18%
⚡	slice_arrow_buffer[65536]	397.8 ns	339.4 ns	+17.18%

Footnotes

1. 235 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[codecov]

Codecov Report

❌ Patch coverage is 88.61789% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.43%. Comparing base (7e1d377) to head (8b07ace).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
vortex-compute/src/take/slice/mod.rs	33.33%	6 Missing ⚠️
vortex-compute/src/take/buffer.rs	0.00%	3 Missing ⚠️
vortex-compute/src/take/slice/avx2.rs	96.62%	3 Missing ⚠️
...ex-array/src/arrays/primitive/compute/take/avx2.rs	90.90%	1 Missing ⚠️
vortex-buffer/src/buffer.rs	90.90%	1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[a10y]

Are we going to handle nullability or is that handled a level up?

[connortsui20]

@a10y yeah I think that it doesnt really make sense to handle nullable indices for a plain buffer, once we add take on things like vectors then we can take a primitive array or pvector as indices

[joseph-isaacs]

Can we name this PR appropriately?

[connortsui20]

@joseph-isaacs why is it not named appropriately? Do you mean it should be named a migration instead?

[connortsui20]

ok I'm just going to port it over now to make things cleaner

cc @a10y since I believe you were the one who implemented the AVX2 impl? Everything is identical except that I pulled out the validity (which was just getting passed in so that it could construct a PrimitiveArray) and I changed a buffer transmute to use a new cast_into method I added on Buffer.

[cloudflare-workers-and-pages]

Deploying vortex-bench with    Cloudflare Pages

Latest commit:	8b07ace
Status:	✅  Deploy successful!
Preview URL:	https://cedce7ce.vortex-93b.pages.dev
Branch Preview URL:	https://ct-take-slice.vortex-93b.pages.dev

View logs

[a10y]

lgtm, avx2 tests are running in CI and still passing