Skip to content

Conversation

@connortsui20
Copy link
Contributor

No description provided.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/chore A trivial change label Nov 24, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 24, 2025

CodSpeed Performance Report

Merging #5509 will degrade performances by 18.23%

Comparing ct/fqi-vector (5ba2455) with develop (cc195d5)1

Summary

⚡ 6 improvements
❌ 8 regressions
✅ 1498 untouched
⏩ 143 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
batch[16384] 127.7 µs 113.1 µs +12.84%
batch[65536] 505.4 µs 447.5 µs +12.95%
in_place_batch[1024] 4.6 µs 5.6 µs -16.79%
in_place_batch[65536] 266.3 µs 208.4 µs +27.78%
in_place_batch[86016] 349 µs 273 µs +27.82%
in_place_pipeline[100352] 154.6 µs 128.9 µs +19.96%
in_place_pipeline[1024] 4.1 µs 5 µs -18.23%
in_place_pipeline[65536] 85.3 µs 102.1 µs -16.45%
pipeline[65536] 89.3 µs 105.1 µs -15.09%
pipeline_extra_copy[100352] 132.9 µs 158.6 µs -16.22%
pipeline_extra_copy[1024] 8 µs 8.9 µs -10.18%
pipeline_extra_copy[16384] 27.9 µs 32.1 µs -13.1%
pipeline_extra_copy[65536] 89.3 µs 105.2 µs -15.13%
verify_all_methods[1024] 306.5 µs 119.8 µs ×2.6

Footnotes

  1. No successful run was found on ct/begin-vertical-imports-migration (1d02918) during the generation of this report, so develop (cc195d5) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 143 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.50%. Comparing base (4a0051e) to head (5ba2455).
⚠️ Report is 5 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from ct/begin-vertical-imports-migration to develop November 24, 2025 21:52
@connortsui20 connortsui20 merged commit 8eedfe5 into develop Nov 24, 2025
41 of 43 checks passed
@connortsui20 connortsui20 deleted the ct/fqi-vector branch November 24, 2025 21:59
a10y pushed a commit that referenced this pull request Nov 25, 2025
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants