Skip to content

Conversation

@connortsui20
Copy link
Contributor

Again, a purely cosmetic change.

(wanted to do this before implementing the batch execute)

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/chore A trivial change label Nov 24, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 24, 2025

CodSpeed Performance Report

Merging #5501 will degrade performances by 18.82%

Comparing ct/dict-refactor (5efe37e) with develop (b5d28a1)

Summary

⚡ 12 improvements
❌ 2 regressions
✅ 1501 untouched
🆕 7 new
⏩ 119 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 decompress[("alp_for_bp_f64", 0x45b7fa0)] N/A 29.8 ms N/A
🆕 decompress[("datetime_for_bp", 0x45baa70)] N/A 41.7 ms N/A
🆕 decompress[("dict_fsst_varbin_bp_string", 0x45b9ef0)] N/A 76.3 ms N/A
🆕 decompress[("dict_fsst_varbin_string", 0x45b9b70)] N/A 76.3 ms N/A
🆕 decompress[("dict_varbinview_string", 0x45b89c0)] N/A 75.6 ms N/A
🆕 decompress[("for_bp_u64", 0x45b7850)] N/A 2.5 ms N/A
🆕 decompress[("runend_for_bp_u32", 0x45b8d50)] N/A 2.1 ms N/A
batch[262144] 1.8 ms 2 ms -11.48%
batch[73728] 568.2 µs 484.2 µs +17.34%
in_place_batch[65536] 249.3 µs 208.4 µs +19.63%
in_place_batch[73728] 299.3 µs 234.3 µs +27.75%
in_place_batch[86016] 326.8 µs 273 µs +19.69%
in_place_pipeline[1024] 4 µs 5 µs -18.82%
in_place_pipeline[262144] 397.3 µs 331.1 µs +20.01%
in_place_pipeline[8192] 15.7 µs 12.7 µs +23.61%
in_place_pipeline[86016] 132 µs 110.9 µs +19.01%
pipeline[16384] 32 µs 27.7 µs +15.24%
pipeline[73728] 118.4 µs 98.6 µs +20.12%
pipeline_extra_copy[8192] 19.7 µs 17.6 µs +11.41%
verify_all_methods[1024] 168 µs 123.5 µs +35.99%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 119 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20 connortsui20 enabled auto-merge (squash) November 24, 2025 19:02
@connortsui20 connortsui20 merged commit 929c372 into develop Nov 24, 2025
47 of 48 checks passed
@connortsui20 connortsui20 deleted the ct/dict-refactor branch November 24, 2025 19:08
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 83.15217% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.61%. Comparing base (b5d28a1) to head (5efe37e).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/arrays/dict/vtable/array.rs 47.36% 10 Missing ⚠️
vortex-array/src/arrays/dict/vtable/encode.rs 0.00% 7 Missing ⚠️
vortex-array/src/arrays/dict/vtable/mod.rs 85.41% 7 Missing ⚠️
vortex-array/src/arrow/convert.rs 0.00% 6 Missing ⚠️
vortex-array/src/arrays/dict/vtable/validity.rs 97.43% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

a10y pushed a commit that referenced this pull request Nov 25, 2025
Again, a purely cosmetic change.

(wanted to do this before implementing the batch execute)

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants