Skip to content

Conversation

@connortsui20
Copy link
Contributor

Since the operator API passes around owned vectors, we probably want to use these filter impls.

It is a good amount of boilerplate, but honestly I think it is fine since we are not likely not adding many more vector types.

@connortsui20 connortsui20 requested review from a10y and gatesn November 24, 2025 16:11
@connortsui20 connortsui20 added the changelog/feature A new feature label Nov 24, 2025
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 24, 2025

CodSpeed Performance Report

Merging #5493 will degrade performances by 30.15%

Comparing ct/vv-filter (f7fe58b) with develop (f56db99)1

Summary

⚡ 3 improvements
❌ 7 regressions
✅ 1495 untouched
🆕 7 new
⏩ 136 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 decompress[("alp_for_bp_f64", 0x45b9060)] N/A 29.8 ms N/A
🆕 decompress[("datetime_for_bp", 0x45bbb30)] N/A 41.7 ms N/A
🆕 decompress[("dict_fsst_varbin_bp_string", 0x45bafb0)] N/A 76.3 ms N/A
🆕 decompress[("dict_fsst_varbin_string", 0x45bac30)] N/A 76.3 ms N/A
🆕 decompress[("dict_varbinview_string", 0x45b9a80)] N/A 75.6 ms N/A
🆕 decompress[("for_bp_u64", 0x45b8910)] N/A 2.5 ms N/A
🆕 decompress[("runend_for_bp_u32", 0x45b9e10)] N/A 2.1 ms N/A
in_place_batch[65536] 208.4 µs 266.3 µs -21.76%
in_place_pipeline[100352] 128.9 µs 154.6 µs -16.63%
in_place_pipeline[16384] 27.2 µs 23.9 µs +13.81%
in_place_pipeline[65536] 102.1 µs 85.3 µs +19.73%
pipeline[100352] 157.6 µs 132.8 µs +18.72%
pipeline[16384] 27.8 µs 32 µs -13.05%
pipeline[86016] 114.9 µs 136 µs -15.53%
pipeline_extra_copy[100352] 132.9 µs 158.6 µs -16.19%
pipeline_extra_copy[86016] 115 µs 137 µs -16.06%
verify_all_methods[1024] 114 µs 163.1 µs -30.15%

Footnotes

  1. No successful run was found on develop (4a0051e) during the generation of this report, so f56db99 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 136 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 5.45455% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.50%. Comparing base (4a0051e) to head (f7fe58b).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-compute/src/filter/vector/binaryview.rs 0.00% 7 Missing ⚠️
vortex-compute/src/filter/vector/bool.rs 0.00% 7 Missing ⚠️
vortex-compute/src/filter/vector/decimal.rs 0.00% 7 Missing ⚠️
vortex-compute/src/filter/vector/dvector.rs 0.00% 7 Missing ⚠️
vortex-compute/src/filter/vector/list.rs 0.00% 7 Missing ⚠️
vortex-compute/src/filter/vector/primitive.rs 0.00% 7 Missing ⚠️
vortex-compute/src/filter/vector/struct_.rs 0.00% 7 Missing ⚠️
vortex-compute/src/filter/vector/null.rs 50.00% 3 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gatesn gatesn merged commit 98b31fb into develop Nov 24, 2025
46 of 47 checks passed
@gatesn gatesn deleted the ct/vv-filter branch November 24, 2025 20:24
a10y pushed a commit that referenced this pull request Nov 25, 2025
Since the operator API passes around owned vectors, we probably want to
use these filter impls.

It is a good amount of boilerplate, but honestly I think it is fine
since we are not likely not adding many more vector types.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants