-
Notifications
You must be signed in to change notification settings - Fork 130
fix: benchmark input handling #5488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #5488 will degrade performances by 23.04%Comparing Summary
Benchmarks breakdown
Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
38c37b0 to
c710e76
Compare
| .with_inputs(|| setup(SIZE)) | ||
| .bench_refs(|(input_data, buffers)| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this back out?
Inputs should be passed `with_inputs` to black box input args and benchmarked with `bench_refs` to exclude `drop`. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com> Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Inputs should be passed `with_inputs` to black box input args and benchmarked with `bench_refs` to exclude `drop`. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Inputs should be passed
with_inputsto black box input args and benchmarked withbench_refsto excludedrop.