-
Notifications
You must be signed in to change notification settings - Fork 130
Revert "Revert "chore[ci]: add windows test to CI (#5439)"" #5486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #5486 will degrade performances by 21.78%Comparing Summary
Benchmarks breakdown
Footnotes
|
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add conditional import of std::os::windows::fs::FileExt on Windows - Use FileExt::seek_read on Windows instead of Unix-specific read_exact_at - Keep fallback implementation for other platforms - Fixes compilation error on Windows where std::os::unix was not available 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
- c_ulong is u32 on Windows but u64 on Unix platforms - Use u64::from() to convert c_ulong values to u64 safely on both platforms - Add clippy allow for useless_conversion (necessary for cross-platform compat) - Fixes type mismatch errors in vortex_ffi::file::vx_file_scan_options 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
Reverts #5449