Skip to content

Conversation

@joseph-isaacs
Copy link
Contributor

Reverts #5449

@joseph-isaacs joseph-isaacs added the changelog/feature A new feature label Nov 24, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 24, 2025

CodSpeed Performance Report

Merging #5486 will degrade performances by 21.78%

Comparing revert-5449-ad/revert-win (e5da645) with develop (f84c6b3)

Summary

⚡ 5 improvements
❌ 9 regressions
✅ 1508 untouched
⏩ 84 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
batch[16384] 113 µs 127.4 µs -11.35%
batch[65536] 505.1 µs 430.5 µs +17.35%
batch[73728] 568.1 µs 503 µs +12.94%
in_place_batch[100352] 318.1 µs 381 µs -16.5%
in_place_batch[86016] 272.9 µs 348.9 µs -21.78%
in_place_pipeline[8192] 13.6 µs 15.8 µs -13.52%
in_place_pipeline[86016] 110.9 µs 133 µs -16.58%
pipeline[100352] 158.5 µs 132.7 µs +19.43%
pipeline[16384] 27.7 µs 31 µs -10.64%
pipeline[86016] 136.9 µs 114.8 µs +19.24%
pipeline_extra_copy[1024] 7.9 µs 8.8 µs -10.28%
pipeline_extra_copy[16384] 27.8 µs 31.9 µs -13.06%
pipeline_extra_copy[8192] 17.5 µs 19.6 µs -10.58%
verify_all_methods[1024] 178.2 µs 151.9 µs +17.34%

Footnotes

  1. 84 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@0ax1 0ax1 self-requested a review November 24, 2025 10:45
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.68%. Comparing base (f52dbf0) to head (e5da645).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-ffi/src/file.rs 0.00% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Add conditional import of std::os::windows::fs::FileExt on Windows
- Use FileExt::seek_read on Windows instead of Unix-specific read_exact_at
- Keep fallback implementation for other platforms
- Fixes compilation error on Windows where std::os::unix was not available

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Signed-off-by: Claude <noreply@anthropic.com>
- c_ulong is u32 on Windows but u64 on Unix platforms
- Use u64::from() to convert c_ulong values to u64 safely on both platforms
- Add clippy allow for useless_conversion (necessary for cross-platform compat)
- Fixes type mismatch errors in vortex_ffi::file::vx_file_scan_options

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs merged commit 3572526 into develop Nov 24, 2025
45 of 46 checks passed
@joseph-isaacs joseph-isaacs deleted the revert-5449-ad/revert-win branch November 24, 2025 15:08
a10y pushed a commit that referenced this pull request Nov 25, 2025
Reverts #5449

---------

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants