Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Nov 22, 2025

No description provided.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/feature A new feature label Nov 22, 2025
@gatesn gatesn requested a review from connortsui20 November 22, 2025 02:11
@gatesn gatesn enabled auto-merge (squash) November 22, 2025 02:11
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 22, 2025

CodSpeed Performance Report

Merging #5461 will degrade performances by 21.42%

Comparing ngates/vector-cast (0875e4f) with develop (b70f635)

Summary

⚡ 32 improvements
❌ 3 regressions
✅ 1480 untouched
🆕 7 new
⏩ 112 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
new_alp_prim_test_between[f32, 16384] 121.9 µs 107 µs +13.95%
new_alp_prim_test_between[f64, 16384] 155.9 µs 139.5 µs +11.75%
new_alp_prim_test_between[f64, 32768] 210.5 µs 177.7 µs +18.47%
new_bp_prim_test_between[i16, 16384] 86.9 µs 72 µs +20.72%
new_bp_prim_test_between[i16, 32768] 142.2 µs 112.3 µs +26.65%
new_bp_prim_test_between[i32, 16384] 104.4 µs 89.6 µs +16.51%
new_bp_prim_test_between[i32, 32768] 175.5 µs 145.7 µs +20.45%
new_bp_prim_test_between[i64, 16384] 137.6 µs 121.3 µs +13.45%
new_bp_prim_test_between[i64, 32768] 241.3 µs 208.6 µs +15.7%
new_raw_prim_test_between[f32, 16384] 93.2 µs 70 µs +33.03%
new_raw_prim_test_between[f32, 2048] 31.1 µs 28.2 µs +10.09%
new_raw_prim_test_between[f32, 32768] 164 µs 117.7 µs +39.34%
new_raw_prim_test_between[f64, 16384] 121.5 µs 97.3 µs +24.85%
new_raw_prim_test_between[f64, 32768] 221.6 µs 173.1 µs +28.02%
new_raw_prim_test_between[i32, 16384] 81 µs 66.2 µs +22.36%
new_raw_prim_test_between[i32, 32768] 140.3 µs 110.5 µs +26.98%
new_raw_prim_test_between[i64, 16384] 110.2 µs 93.8 µs +17.42%
new_raw_prim_test_between[i64, 32768] 198.3 µs 165.6 µs +19.79%
new_raw_prim_test_between[u32, 16384] 82.5 µs 67.7 µs +21.95%
new_raw_prim_test_between[u32, 32768] 142.5 µs 112.7 µs +26.43%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 112 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.60%. Comparing base (b70f635) to head (0875e4f).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-compute/src/cast/bool.rs 0.00% 18 Missing ⚠️
vortex-compute/src/cast/pvector.rs 0.00% 15 Missing ⚠️
vortex-array/src/expr/exprs/cast/mod.rs 0.00% 9 Missing ⚠️
vortex-array/src/expr/exprs/select/mod.rs 0.00% 9 Missing ⚠️
vortex-compute/src/cast/mod.rs 0.00% 7 Missing ⚠️
vortex-compute/src/cast/null.rs 0.00% 7 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 24, 2025

Deploying vortex-bench with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0875e4f
Status: ✅  Deploy successful!
Preview URL: https://3161be07.vortex-93b.pages.dev
Branch Preview URL: https://ngates-vector-cast.vortex-93b.pages.dev

View logs

@gatesn gatesn merged commit b5d28a1 into develop Nov 24, 2025
46 of 47 checks passed
@gatesn gatesn deleted the ngates/vector-cast branch November 24, 2025 18:31
a10y pushed a commit that referenced this pull request Nov 25, 2025
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants