Skip to content

Conversation

@robert3005
Copy link
Contributor

Signed-off-by: Robert Kruszewski github@robertk.io

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 changed the title fix: Support stdFile on windows as it's used by cxx bindings fix: Support std_file on windows as it's used by cxx bindings Nov 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025

CodSpeed Performance Report

Merging #5450 will degrade performances by 39.33%

Comparing rk/stdfile (0c8e7f5) with develop (c83ec8a)

Summary

⚡ 8 improvements
❌ 8 regressions
✅ 1506 untouched
⏩ 14 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
batch[100352] 684.2 µs 772.9 µs -11.47%
in_place_batch[1024] 4.7 µs 5.6 µs -16.27%
in_place_batch[16384] 67.8 µs 53.3 µs +27.2%
in_place_batch[65536] 266.3 µs 208.4 µs +27.8%
in_place_pipeline[100352] 153.7 µs 128.8 µs +19.29%
in_place_pipeline[86016] 132.1 µs 110.9 µs +19.06%
pipeline[100352] 157.7 µs 132.9 µs +18.66%
pipeline[1024] 7.9 µs 8.9 µs -11.13%
pipeline[8192] 19.6 µs 17.6 µs +11.61%
pipeline[86016] 114.9 µs 136.1 µs -15.56%
pipeline_extra_copy[65536] 106.1 µs 89.3 µs +18.8%
pipeline_extra_copy[73728] 99.5 µs 118.5 µs -16.02%
pipeline_extra_copy[8192] 19.7 µs 17.6 µs +11.57%
pipeline_extra_copy[86016] 114.9 µs 136.1 µs -15.56%
verify_all_methods[1024] 317.5 µs 383.7 µs -17.23%
verify_all_methods[16384] 22.7 ms 37.5 ms -39.33%

Footnotes

  1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (95972bc) to head (0c8e7f5).
⚠️ Report is 6 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robert3005 robert3005 added the changelog/feature A new feature label Nov 21, 2025
@robert3005 robert3005 changed the title fix: Support std_file on windows as it's used by cxx bindings feature: Support std_file on windows as it's used by cxx bindings Nov 21, 2025
@gatesn gatesn merged commit 5dbe73e into develop Nov 21, 2025
44 of 46 checks passed
@gatesn gatesn deleted the rk/stdfile branch November 21, 2025 21:55
a10y pushed a commit that referenced this pull request Nov 25, 2025
)

Signed-off-by: Robert Kruszewski <github@robertk.io>

Signed-off-by: Robert Kruszewski <github@robertk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants