Skip to content

Conversation

@robert3005
Copy link
Contributor

@robert3005 robert3005 commented Nov 21, 2025

fix: #5373

I think we could have these do RAII but we need something better than just scalar_at

Signed-off-by: Robert Kruszewski github@robertk.io

…uess the necessary memory

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025

Too many benchmarks in a single upload

The performance report could not be generated because there were too many benchmarks in a single upload to CodSpeed. We recommend sharding your benchmarks into smaller uploads, see the documentation for more information.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 93.58974% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.99%. Comparing base (4321359) to head (5027506).
⚠️ Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-ffi/src/dtype.rs 0.00% 3 Missing ⚠️
vortex-ffi/src/array.rs 92.30% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@joseph-isaacs joseph-isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nnice

@joseph-isaacs joseph-isaacs merged commit 20d88e3 into develop Nov 21, 2025
38 of 39 checks passed
@joseph-isaacs joseph-isaacs deleted the rk/ffistringblob branch November 21, 2025 12:24
a10y pushed a commit that referenced this pull request Nov 25, 2025
…uess the necessary memory (#5433)

fix: #5373 

I think we could have these do RAII but we need something better than
just scalar_at

Signed-off-by: Robert Kruszewski <github@robertk.io>

---------

Signed-off-by: Robert Kruszewski <github@robertk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FFI unsafe API endpoints

3 participants