Skip to content

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Nov 19, 2025

See the analysis in the file itself for more details.

Here are the numbers I got on my AMD 7950X CPU:

Timer precision: 10 ns
pipeline                     fastest       │ slowest       │ median        │ mean          │ samples │ iters
├─ correctness_verification                │               │               │               │         │
│  ╰─ verify_all_methods                   │               │               │               │         │
│     ├─ 1024                21.67 µs      │ 79.2 µs       │ 28.41 µs      │ 30.07 µs      │ 3145    │ 3145
│     ╰─ 16384               2.105 ms      │ 7.156 ms      │ 2.4 ms        │ 3.142 ms      │ 100     │ 100
╰─ decompress_benchmarks                   │               │               │               │         │
   ├─ batch                                │               │               │               │         │
   │  ├─ 1024                218.5 ns      │ 3.677 µs      │ 223.5 ns      │ 225.4 ns      │ 460458  │ 3683664
   │  ├─ 8192                1.809 µs      │ 29.41 µs      │ 1.869 µs      │ 1.88 µs       │ 445049  │ 445049
   │  ├─ 16384               3.589 µs      │ 42.26 µs      │ 3.669 µs      │ 3.699 µs      │ 245287  │ 245287
   │  ├─ 65536               14.89 µs      │ 41.38 µs      │ 15.16 µs      │ 15.4 µs       │ 62931   │ 62931
   │  ├─ 73728               16.92 µs      │ 47.76 µs      │ 18.15 µs      │ 18.18 µs      │ 53463   │ 53463
   │  ├─ 86016               20.22 µs      │ 95.48 µs      │ 20.66 µs      │ 20.95 µs      │ 46441   │ 46441
   │  ├─ 100352              23.92 µs      │ 141.6 µs      │ 24.46 µs      │ 24.86 µs      │ 39312   │ 39312
   │  ╰─ 262144              64.36 µs      │ 377.9 µs      │ 66.16 µs      │ 67.01 µs      │ 14794   │ 14794
   ├─ in_place_batch                       │               │               │               │         │
   │  ├─ 1024                212.3 ns      │ 5.053 µs      │ 217.3 ns      │ 218.9 ns      │ 470820  │ 3766560
   │  ├─ 8192                1.739 µs      │ 30.48 µs      │ 1.799 µs      │ 1.809 µs      │ 458869  │ 458869
   │  ├─ 16384               3.459 µs      │ 38.94 µs      │ 3.529 µs      │ 3.542 µs      │ 255618  │ 255618
   │  ├─ 65536               14.27 µs      │ 53.86 µs      │ 14.63 µs      │ 14.76 µs      │ 66042   │ 66042
   │  ├─ 73728               15.52 µs      │ 45.09 µs      │ 15.94 µs      │ 16.02 µs      │ 60967   │ 60967
   │  ├─ 86016               17.98 µs      │ 80.87 µs      │ 18.44 µs      │ 18.54 µs      │ 52746   │ 52746
   │  ├─ 100352              20.85 µs      │ 99.88 µs      │ 21.46 µs      │ 21.57 µs      │ 45497   │ 45497
   │  ╰─ 262144              58.74 µs      │ 114.2 µs      │ 59.04 µs      │ 59.82 µs      │ 16552   │ 16552
   ├─ in_place_pipeline                    │               │               │               │         │
   │  ├─ 1024                207.3 ns      │ 9.616 µs      │ 213.5 ns      │ 214.3 ns      │ 478786  │ 3830288
   │  ├─ 8192                1.649 µs      │ 245.5 µs      │ 1.709 µs      │ 1.719 µs      │ 479444  │ 479444
   │  ├─ 16384               3.289 µs      │ 39.84 µs      │ 3.359 µs      │ 3.371 µs      │ 267173  │ 267173
   │  ├─ 65536               13.01 µs      │ 45.35 µs      │ 13.31 µs      │ 13.41 µs      │ 72524   │ 72524
   │  ├─ 73728               14.7 µs       │ 50.16 µs      │ 14.99 µs      │ 15.06 µs      │ 64793   │ 64793
   │  ├─ 86016               17.01 µs      │ 43.34 µs      │ 17.48 µs      │ 17.59 µs      │ 55669   │ 55669
   │  ├─ 100352              20.02 µs      │ 48.37 µs      │ 20.4 µs       │ 20.57 µs      │ 47724   │ 47724
   │  ╰─ 262144              52.46 µs      │ 86.05 µs      │ 53.27 µs      │ 53.6 µs       │ 18523   │ 18523
   ├─ pipeline                             │               │               │               │         │
   │  ├─ 1024                208.5 ns      │ 6.634 µs      │ 213.5 ns      │ 215.5 ns      │ 477313  │ 3818504
   │  ├─ 8192                1.659 µs      │ 24.7 µs       │ 1.699 µs      │ 1.707 µs      │ 482728  │ 482728
   │  ├─ 16384               3.289 µs      │ 32.9 µs       │ 3.369 µs      │ 3.393 µs      │ 265702  │ 265702
   │  ├─ 65536               13.1 µs       │ 33.87 µs      │ 13.31 µs      │ 13.4 µs       │ 72563   │ 72563
   │  ├─ 73728               15.09 µs      │ 48.79 µs      │ 15.36 µs      │ 15.49 µs      │ 63019   │ 63019
   │  ├─ 86016               17.28 µs      │ 44.51 µs      │ 17.47 µs      │ 17.62 µs      │ 55584   │ 55584
   │  ├─ 100352              20.24 µs      │ 44.49 µs      │ 20.62 µs      │ 20.78 µs      │ 47268   │ 47268
   │  ╰─ 262144              54.16 µs      │ 89.19 µs      │ 55.6 µs       │ 56.01 µs      │ 17730   │ 17730
   ╰─ pipeline_extra_copy                  │               │               │               │         │
      ├─ 1024                213.5 ns      │ 3.454 µs      │ 232.3 ns      │ 233.4 ns      │ 446407  │ 3571256
      ├─ 8192                1.649 µs      │ 32.93 µs      │ 1.779 µs      │ 1.798 µs      │ 461071  │ 461071
      ├─ 16384               3.279 µs      │ 19.76 µs      │ 3.359 µs      │ 3.379 µs      │ 266614  │ 266614
      ├─ 65536               12.97 µs      │ 55.99 µs      │ 13.27 µs      │ 13.39 µs      │ 72613   │ 72613
      ├─ 73728               14.65 µs      │ 52.98 µs      │ 14.94 µs      │ 15.07 µs      │ 64736   │ 64736
      ├─ 86016               17.15 µs      │ 40.08 µs      │ 17.43 µs      │ 17.55 µs      │ 55777   │ 55777
      ├─ 100352              19.99 µs      │ 59.83 µs      │ 20.32 µs      │ 20.45 µs      │ 48023   │ 48023
      ╰─ 262144              52.21 µs      │ 72.9 µs       │ 53.02 µs      │ 53.33 µs      │ 18614   │ 18614

@connortsui20 connortsui20 requested a review from gatesn November 19, 2025 20:20
@connortsui20 connortsui20 added the changelog/performance A performance improvement label Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.10%. Comparing base (aaf5245) to head (4f50525).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
encodings/alp/src/alp/mod.rs 0.00% 5 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@connortsui20 connortsui20 force-pushed the ct/handwrite-pipeline branch 2 times, most recently from 8d57d6c to 53db86a Compare November 20, 2025 16:30
@connortsui20 connortsui20 marked this pull request as draft November 20, 2025 16:37
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 marked this pull request as ready for review November 20, 2025 17:00
@connortsui20 connortsui20 enabled auto-merge (squash) November 20, 2025 19:12
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 enabled auto-merge (squash) November 20, 2025 19:32
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 20, 2025

Too many benchmarks in a single upload

The performance report could not be generated because there were too many benchmarks in a single upload to CodSpeed. We recommend sharding your benchmarks into smaller uploads, see the documentation for more information.

@connortsui20 connortsui20 merged commit 815a4e2 into develop Nov 20, 2025
37 of 38 checks passed
@connortsui20 connortsui20 deleted the ct/handwrite-pipeline branch November 20, 2025 19:40
a10y pushed a commit that referenced this pull request Nov 25, 2025
See the analysis in the file itself for more details.

Here are the numbers I got on my AMD 7950X CPU:

```
Timer precision: 10 ns
pipeline                     fastest       │ slowest       │ median        │ mean          │ samples │ iters
├─ correctness_verification                │               │               │               │         │
│  ╰─ verify_all_methods                   │               │               │               │         │
│     ├─ 1024                21.67 µs      │ 79.2 µs       │ 28.41 µs      │ 30.07 µs      │ 3145    │ 3145
│     ╰─ 16384               2.105 ms      │ 7.156 ms      │ 2.4 ms        │ 3.142 ms      │ 100     │ 100
╰─ decompress_benchmarks                   │               │               │               │         │
   ├─ batch                                │               │               │               │         │
   │  ├─ 1024                218.5 ns      │ 3.677 µs      │ 223.5 ns      │ 225.4 ns      │ 460458  │ 3683664
   │  ├─ 8192                1.809 µs      │ 29.41 µs      │ 1.869 µs      │ 1.88 µs       │ 445049  │ 445049
   │  ├─ 16384               3.589 µs      │ 42.26 µs      │ 3.669 µs      │ 3.699 µs      │ 245287  │ 245287
   │  ├─ 65536               14.89 µs      │ 41.38 µs      │ 15.16 µs      │ 15.4 µs       │ 62931   │ 62931
   │  ├─ 73728               16.92 µs      │ 47.76 µs      │ 18.15 µs      │ 18.18 µs      │ 53463   │ 53463
   │  ├─ 86016               20.22 µs      │ 95.48 µs      │ 20.66 µs      │ 20.95 µs      │ 46441   │ 46441
   │  ├─ 100352              23.92 µs      │ 141.6 µs      │ 24.46 µs      │ 24.86 µs      │ 39312   │ 39312
   │  ╰─ 262144              64.36 µs      │ 377.9 µs      │ 66.16 µs      │ 67.01 µs      │ 14794   │ 14794
   ├─ in_place_batch                       │               │               │               │         │
   │  ├─ 1024                212.3 ns      │ 5.053 µs      │ 217.3 ns      │ 218.9 ns      │ 470820  │ 3766560
   │  ├─ 8192                1.739 µs      │ 30.48 µs      │ 1.799 µs      │ 1.809 µs      │ 458869  │ 458869
   │  ├─ 16384               3.459 µs      │ 38.94 µs      │ 3.529 µs      │ 3.542 µs      │ 255618  │ 255618
   │  ├─ 65536               14.27 µs      │ 53.86 µs      │ 14.63 µs      │ 14.76 µs      │ 66042   │ 66042
   │  ├─ 73728               15.52 µs      │ 45.09 µs      │ 15.94 µs      │ 16.02 µs      │ 60967   │ 60967
   │  ├─ 86016               17.98 µs      │ 80.87 µs      │ 18.44 µs      │ 18.54 µs      │ 52746   │ 52746
   │  ├─ 100352              20.85 µs      │ 99.88 µs      │ 21.46 µs      │ 21.57 µs      │ 45497   │ 45497
   │  ╰─ 262144              58.74 µs      │ 114.2 µs      │ 59.04 µs      │ 59.82 µs      │ 16552   │ 16552
   ├─ in_place_pipeline                    │               │               │               │         │
   │  ├─ 1024                207.3 ns      │ 9.616 µs      │ 213.5 ns      │ 214.3 ns      │ 478786  │ 3830288
   │  ├─ 8192                1.649 µs      │ 245.5 µs      │ 1.709 µs      │ 1.719 µs      │ 479444  │ 479444
   │  ├─ 16384               3.289 µs      │ 39.84 µs      │ 3.359 µs      │ 3.371 µs      │ 267173  │ 267173
   │  ├─ 65536               13.01 µs      │ 45.35 µs      │ 13.31 µs      │ 13.41 µs      │ 72524   │ 72524
   │  ├─ 73728               14.7 µs       │ 50.16 µs      │ 14.99 µs      │ 15.06 µs      │ 64793   │ 64793
   │  ├─ 86016               17.01 µs      │ 43.34 µs      │ 17.48 µs      │ 17.59 µs      │ 55669   │ 55669
   │  ├─ 100352              20.02 µs      │ 48.37 µs      │ 20.4 µs       │ 20.57 µs      │ 47724   │ 47724
   │  ╰─ 262144              52.46 µs      │ 86.05 µs      │ 53.27 µs      │ 53.6 µs       │ 18523   │ 18523
   ├─ pipeline                             │               │               │               │         │
   │  ├─ 1024                208.5 ns      │ 6.634 µs      │ 213.5 ns      │ 215.5 ns      │ 477313  │ 3818504
   │  ├─ 8192                1.659 µs      │ 24.7 µs       │ 1.699 µs      │ 1.707 µs      │ 482728  │ 482728
   │  ├─ 16384               3.289 µs      │ 32.9 µs       │ 3.369 µs      │ 3.393 µs      │ 265702  │ 265702
   │  ├─ 65536               13.1 µs       │ 33.87 µs      │ 13.31 µs      │ 13.4 µs       │ 72563   │ 72563
   │  ├─ 73728               15.09 µs      │ 48.79 µs      │ 15.36 µs      │ 15.49 µs      │ 63019   │ 63019
   │  ├─ 86016               17.28 µs      │ 44.51 µs      │ 17.47 µs      │ 17.62 µs      │ 55584   │ 55584
   │  ├─ 100352              20.24 µs      │ 44.49 µs      │ 20.62 µs      │ 20.78 µs      │ 47268   │ 47268
   │  ╰─ 262144              54.16 µs      │ 89.19 µs      │ 55.6 µs       │ 56.01 µs      │ 17730   │ 17730
   ╰─ pipeline_extra_copy                  │               │               │               │         │
      ├─ 1024                213.5 ns      │ 3.454 µs      │ 232.3 ns      │ 233.4 ns      │ 446407  │ 3571256
      ├─ 8192                1.649 µs      │ 32.93 µs      │ 1.779 µs      │ 1.798 µs      │ 461071  │ 461071
      ├─ 16384               3.279 µs      │ 19.76 µs      │ 3.359 µs      │ 3.379 µs      │ 266614  │ 266614
      ├─ 65536               12.97 µs      │ 55.99 µs      │ 13.27 µs      │ 13.39 µs      │ 72613   │ 72613
      ├─ 73728               14.65 µs      │ 52.98 µs      │ 14.94 µs      │ 15.07 µs      │ 64736   │ 64736
      ├─ 86016               17.15 µs      │ 40.08 µs      │ 17.43 µs      │ 17.55 µs      │ 55777   │ 55777
      ├─ 100352              19.99 µs      │ 59.83 µs      │ 20.32 µs      │ 20.45 µs      │ 48023   │ 48023
      ╰─ 262144              52.21 µs      │ 72.9 µs       │ 53.02 µs      │ 53.33 µs      │ 18614   │ 18614
```

---------

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants