Skip to content

Conversation

@robert3005
Copy link
Contributor

@robert3005 robert3005 commented Nov 19, 2025

fix #5391

Signed-off-by: Robert Kruszewski github@robertk.io

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/fix A bug fix label Nov 19, 2025
@robert3005 robert3005 enabled auto-merge (squash) November 19, 2025 07:52
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.98%. Comparing base (28f0989) to head (2fcee0e).
⚠️ Report is 5 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Andrew Duffy <andrew@a10y.dev>
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 19, 2025

CodSpeed Performance Report

Merging #5396 will improve performances by 16.01%

Comparing rk/ffifixes (2fcee0e) with develop (dc03c4f)

Summary

⚡ 1 improvement
✅ 1427 untouched
⏩ 666 skipped1
🗄️ 28 archived benchmarks run2

Benchmarks breakdown

Benchmark BASE HEAD Change
encode_specialized 1.2 ms 1.1 ms +16.01%

Footnotes

  1. 666 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 28 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

@robert3005 robert3005 merged commit cff218e into develop Nov 19, 2025
38 checks passed
@robert3005 robert3005 deleted the rk/ffifixes branch November 19, 2025 13:59
@robert3005
Copy link
Contributor Author

thanks @a10y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FFI inconsistency with field idx type

4 participants