feat: PyExpr::evaluate #5388
Merged
feat: PyExpr::evaluate #5388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is primarily useful for diagnosing issues (e.g. #5385). Signed-off-by: Daniel King <dan@spiraldb.com>
danking
force-pushed
the
dk/pyexpr-evaluate
branch
from
198bdef to
4cbc8d9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Daniel King <dan@spiraldb.com>
robert3005
approved these changes
Nov 18, 2025
robert3005
reviewed
Nov 18, 2025
| # TypeAliases do not support __doc__. | ||
| IntoProjection: TypeAlias = Expr | list[str] | None | ||
| IntoArrayIterator: TypeAlias = Array | ArrayIterator | pa.Table | pa.RecordBatchReader | ||
| IntoArray: TypeAlias = Union[Array, "pa.Array[pa.Scalar[pa.DataType]]", pa.Table] |
Contributor
There was a problem hiding this comment.
you have pyright yelling at you to use |
Contributor
Author
There was a problem hiding this comment.
The stubs disagree with actual pyarrow so I can't use |. I ignored the lint.
Contributor
Author
There was a problem hiding this comment.
(and | dislikes strings)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily useful for diagnosing issues (e.g. #5385).