Skip to content

Conversation

@a10y
Copy link
Contributor

@a10y a10y commented Nov 18, 2025

I wrote the unit test, it failed, stepped through it in debugger, noticed that span was always zero. We always clear the lowest bit and then check for trailing_ones, so we never copied anything.

Fixes the logic to actually copy runs of values. Test passes now.

@a10y a10y requested review from connortsui20 and gatesn November 18, 2025 15:59
@a10y a10y force-pushed the aduffy/fix-bitview-filter branch 2 times, most recently from f3c0205 to aa43dcd Compare November 18, 2025 16:01
@a10y a10y added the changelog/fix A bug fix label Nov 18, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 18, 2025

CodSpeed Performance Report

Merging #5381 will not alter performance

Comparing aduffy/fix-bitview-filter (6cab3ed) with develop (e269163)

Summary

✅ 1428 untouched
⏩ 645 skipped1
🗄️ 28 archived benchmarks run2

Footnotes

  1. 645 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 28 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (e269163) to head (6cab3ed).
⚠️ Report is 5 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

I wrote the unit test, it failed, stepped through it in debugger,
noticed that span was always zero. We always clear the lowest bit and
then check for trailing_ones, so we never copied anything.

Fixes the logic to actually copy runs of values. Test passes now.

Signed-off-by: Andrew Duffy <andrew@a10y.dev>
@a10y a10y force-pushed the aduffy/fix-bitview-filter branch from 9e7ee70 to 6cab3ed Compare November 18, 2025 22:31
@joseph-isaacs joseph-isaacs merged commit 7c76e43 into develop Nov 19, 2025
62 of 63 checks passed
@joseph-isaacs joseph-isaacs deleted the aduffy/fix-bitview-filter branch November 19, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants