-
Notifications
You must be signed in to change notification settings - Fork 130
Faster Pipelines #5352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster Pipelines #5352
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
| use crate::pipeline::N; | ||
| use vortex_compute::filter::Filter; | ||
|
|
||
| impl<'a, T: Copy> Filter<BitView<'a>> for &'a mut [T] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually very useful to have highly specialized filter kernels for N elements. So I think we keep these here, outside the vortex-compute package, possibly delegating to vortex-compute where possible.
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
CodSpeed Performance ReportMerging #5352 will degrade performances by 25.7%Comparing Summary
Benchmarks breakdownFootnotes
|
|
Hello, CodSpeed team member here. We had some trouble processing the results in your latest run, due to the large number of uploaded benchmarks. We have some limitations on our side that we are currently working on. In the meantime, could you consider sharding the benchmarks into more than 2 jobs? It should fix the issue for now. Here are some docs on benchmark sharding. |
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Removes a bunch of the pipeline calling overhead.