Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Nov 6, 2025

No description provided.

@gatesn gatesn added the action/benchmark Trigger full benchmarks to run on this PR label Nov 6, 2025
@github-actions github-actions bot removed the action/benchmark Trigger full benchmarks to run on this PR label Nov 6, 2025
@a10y
Copy link
Contributor

a10y commented Nov 6, 2025

There's a clippy lint to prevent this https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call

But obviously it just doesn't apply to our custom vortex_expect

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@a10y a10y force-pushed the ngates/no-eager-formatting branch from 3e5cede to 6382db8 Compare November 6, 2025 21:45
@a10y a10y enabled auto-merge (squash) November 6, 2025 21:45
@a10y a10y added the changelog/fix A bug fix label Nov 6, 2025
to prevent dynamic format strings

Signed-off-by: Andrew Duffy <andrew@a10y.dev>
@a10y a10y force-pushed the ngates/no-eager-formatting branch from 6382db8 to 53a5258 Compare November 6, 2025 21:46
@a10y
Copy link
Contributor

a10y commented Nov 6, 2025

I pushed a commit forcing the message argument of vortex_expect to have &'static lifetime which should prevent this from happening in the future

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.46%. Comparing base (ee4b921) to head (53a5258).
⚠️ Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/compute/conformance/cast.rs 27.27% 8 Missing ⚠️
vortex-array/src/patches.rs 20.00% 4 Missing ⚠️
vortex-session/src/lib.rs 50.00% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@a10y a10y merged commit e8a81e4 into develop Nov 6, 2025
64 of 65 checks passed
@a10y a10y deleted the ngates/no-eager-formatting branch November 6, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants