experiment: eagerly decode dict on read #5229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a10y
commented
Nov 6, 2025
| ) | ||
| .vortex_expect("must construct dict values array evaluation") | ||
| .map_err(Arc::new) | ||
| .map_ok(|arr| arr.to_canonical().into_array()) |
Contributor
Author
There was a problem hiding this comment.
"before" is just running the example with this commented out
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: GitHub Archive (NVMe)Summary
Detailed Results Table
|
Contributor
Benchmarks: GitHub Archive (S3)Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
joseph-isaacs
approved these changes
Nov 6, 2025
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
LGTM, we ca revisit in the operator world
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full scan of Clickbench increases by 35%, from 5 seconds -> ~3.2 seconds
Profile from before: https://share.firefox.dev/3JK7h73
Profile from this commit: https://share.firefox.dev/47GHkNB
Signed-off-by: Andrew Duffy andrew@a10y.dev